Denver Property Tax Relief #4833

hua7450 · 2024-08-03T04:17:42Z

Fixes #4782

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

Fixes PolicyEngine#4782

policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/amount.yaml

policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/rate/homeowner.yaml

policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/rate/renter.yaml

policyengine_us/parameters/gov/local/co/denver/property_tax_relief/maximum_amount/renter.yaml

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

hua7450 · 2024-08-06T14:32:09Z

This PR assigns the maximum values for households that are eligible for the program, following the methods used in Gary-Community-Ventures/benefits-api#461.

policyengine_us/variables/gov/local/co/denver/property_tax_relief/denver_property_tax_relief.py

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/ami.yaml

policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/rate/homeowner.yaml

policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/rate/renter.yaml

...cyengine_us/parameters/gov/local/co/denver/property_tax_relief/maximum_amount/homeowner.yaml

policyengine_us/parameters/gov/local/co/denver/property_tax_relief/maximum_amount/renter.yaml

...us/variables/gov/local/co/denver/property_tax_relief/denver_property_tax_relief_homeowner.py

...ne_us/variables/gov/local/co/denver/property_tax_relief/denver_property_tax_relief_renter.py

...local/co/denver/property_tax_relief/eligibility/co_de_property_tax_relief_renter_eligible.py

...al/co/denver/property_tax_relief/eligibility/co_de_property_tax_relief_homeowner_eligible.py

...ine_us/variables/gov/local/co/denver/property_tax_relief/co_de_property_tax_relief_renter.py

..._us/variables/gov/local/co/denver/property_tax_relief/co_de_property_tax_relief_homeowner.py

policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/rate/renter.yaml

changelog_entry.yaml

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

codecov · 2024-08-13T00:08:20Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (f57467b) to head (98b8185).
Report is 32 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #4833    +/-   ##
========================================
  Coverage   99.00%   99.01%            
========================================
  Files        2536     2555    +19     
  Lines       36845    37133   +288     
  Branches      152      158     +6     
========================================
+ Hits        36479    36767   +288     
  Misses        337      337            
  Partials       29       29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

policyengine_us/variables/household/income/household/household_state_benefits.py

...gine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/maximum_amount/homeowner.yaml

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

policyengine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/ami/ami.yaml

policyengine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/ami/rate/homeowner.yaml

...variables/gov/local/co/denver/dhs/property_tax_relief/co_de_property_tax_relief_homeowner.py

policyengine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/ami/rate/homeowner.yaml

...o/denver/dhs/property_tax_relief/eligibility/co_de_property_tax_relief_homeowner_eligible.py

minor change

…engine-us into hua7450/issue4782

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

…engine-us into hua7450/issue4782

undo changes in reform folder

...ariables/gov/local/co/denver/dhs/property_tax_relief/co_denver_property_tax_relief_income.py

...nver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_homeowner_eligible.py

policyengine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/income.yaml

.../denver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_renter_eligible.py

policyengine_us/variables/household/income/household/household_state_benefits.py

…" does not work and caused error

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

...nver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_homeowner_eligible.py

minor change

.../denver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_renter_eligible.py

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

policyengine_us/variables/gov/local/co/denver/dhs/is_co_denver_dhs_elderly.py

MaxGhenis · 2024-08-21T15:19:24Z

...nver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_homeowner_eligible.py

+        income = spm_unit("co_denver_property_tax_relief_income", period)
+        size = spm_unit("spm_unit_size", period)
+        ami = spm_unit.household("ami", period)
+        p_hud = parameters(period).gov.hud.ami_limit


could we refactor the file this logic is from to avoid duplication? maybe create separate variables for each of the limits, and use the moderate one here? especially since also in the renter variable

Can I combine those variables into one, like my current version? The downside of my current code is I have to input hud_income_level = MODERATE in test cases.

...nver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_homeowner_eligible.py

MaxGhenis · 2024-08-21T22:13:42Z

policyengine_us/variables/gov/hud/hud_income_level_factor.py

Can you refactor the original file? As is this duplicates much of the logic.

…_factor

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

MaxGhenis

final stretch here - we may want to refactor further to have the capped and excess size be their own variables (and making 4 a parameter) to reduce duplication, but this works for now

MaxGhenis · 2024-08-22T03:43:12Z

policyengine_us/variables/gov/hud/income_level_factor/hud_especially_low_income_factor.py

+    definition_period = YEAR
+
+    def formula(spm_unit, period, parameters):
+        p_hud = parameters(period).gov.hud.ami_limit


Suggested change

p_hud = parameters(period).gov.hud.ami_limit

p = parameters(period).gov.hud.ami_limit

MaxGhenis · 2024-08-22T03:44:04Z

policyengine_us/variables/gov/hud/income_level_factor/hud_especially_low_income_factor.py

+        size_exceeding_4 = max_(size - 4, 0)
+        size_capped_at_4 = min_(size, 4)
+        return (
+            size_limit.ESPECIALLY_LOW[size_capped_at_4]


same for the excess and other files - in general please keep the p. in where reasonable to indicate it's a parameter

Suggested change

size_limit.ESPECIALLY_LOW[size_capped_at_4]

p.family_size.ESPECIALLY_LOW[size_capped_at_4]

hua7450 added 3 commits August 3, 2024 04:17

Denver Property Tax Relief

72effde

upstream master

b68c403

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

Denver Property Tax Relief

31eba64

Fixes PolicyEngine#4782

PavelMakarchuk requested changes Aug 5, 2024

View reviewed changes

hua7450 added 2 commits August 6, 2024 14:27

minor change

c2324bb

upstream master

9640c7b

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

hua7450 requested a review from PavelMakarchuk August 6, 2024 14:28

hua7450 mentioned this pull request Aug 6, 2024

Denver Property Tax Relief phase out #4837

Open

PavelMakarchuk requested changes Aug 7, 2024

View reviewed changes

hua7450 added 2 commits August 7, 2024 21:49

separate main file to 3 files

334a46f

upstream master

ce66220

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

PavelMakarchuk requested changes Aug 7, 2024

View reviewed changes

separate eligible and amount files

b66a5cd

PavelMakarchuk requested changes Aug 12, 2024

View reviewed changes

hua7450 added 2 commits August 12, 2024 23:28

reorgainze folder as co/denver/dhs/property_tax_relief

99c2858

upstream master

319fa1c

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

PavelMakarchuk requested changes Aug 13, 2024

View reviewed changes

hua7450 added 3 commits August 13, 2024 01:06

rename parameter folder name

3647e6a

make format

7a69107

upstream master

1b4ffcb

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

hua7450 requested a review from PavelMakarchuk August 14, 2024 03:30

PavelMakarchuk approved these changes Aug 15, 2024

View reviewed changes

PavelMakarchuk marked this pull request as ready for review August 15, 2024 13:49

PavelMakarchuk requested a review from MaxGhenis August 15, 2024 13:49

MaxGhenis requested changes Aug 15, 2024

View reviewed changes

hua7450 added 3 commits August 15, 2024 21:14

renaming all files that has "de" to "denver"

80ab36a

minor change

renaming all files that has "de" to "denver"

f5b2d2c

minor change

Merge branch 'hua7450/issue4782' of https://github.com/hua7450/policy…

f08ce93

…engine-us into hua7450/issue4782

hua7450 added 8 commits August 15, 2024 21:47

undo files change in reform folder

beab377

upstream master

4c62e25

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

Merge branch 'hua7450/issue4782' of https://github.com/hua7450/policy…

7e52b5f

…engine-us into hua7450/issue4782

add income list

a601c43

undo changes in reform folder

make format

d461293

make format

81bd77e

make format

8921672

add integraton test

cbcd951

PavelMakarchuk reviewed Aug 19, 2024

View reviewed changes

...ariables/gov/local/co/denver/dhs/property_tax_relief/co_denver_property_tax_relief_income.py Outdated Show resolved Hide resolved

PavelMakarchuk reviewed Aug 19, 2024

View reviewed changes

...nver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_homeowner_eligible.py Outdated Show resolved Hide resolved

PavelMakarchuk reviewed Aug 19, 2024

View reviewed changes

...nver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_homeowner_eligible.py Outdated Show resolved Hide resolved

MaxGhenis requested changes Aug 19, 2024

View reviewed changes

hua7450 added 2 commits August 19, 2024 16:03

add formula for the homeowner and renter amount, the previes adds=",,…

c2c7ad2

…" does not work and caused error

upstream master

46fec14

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

MaxGhenis reviewed Aug 19, 2024

View reviewed changes

...nver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_homeowner_eligible.py Outdated Show resolved Hide resolved

create household_local_benefits parameter and formula

681385e

minor change

MaxGhenis reviewed Aug 19, 2024

View reviewed changes

.../denver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_renter_eligible.py Outdated Show resolved Hide resolved

hua7450 added 4 commits August 20, 2024 23:38

make format and references change

361717b

upstream master

2c73ce6

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

apply new apporach of using AMI in formula

e9f3232

apply the adds function for single amout parameter

c4aaec2

MaxGhenis requested changes Aug 21, 2024

View reviewed changes

add hud_income_level_factor.py and adjust formula

4c802f7

MaxGhenis reviewed Aug 21, 2024

View reviewed changes

hua7450 added 2 commits August 22, 2024 00:45

refactor hud_income_level.py and create a folder for hud_income_level…

7fbad58

…_factor

upstream master

e2753a5

Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782

MaxGhenis requested changes Aug 22, 2024

View reviewed changes

minor change on hud income factor

98b8185

MaxGhenis approved these changes Aug 22, 2024

View reviewed changes

MaxGhenis merged commit c3202e9 into PolicyEngine:master Aug 22, 2024
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Denver Property Tax Relief #4833

Denver Property Tax Relief #4833

hua7450 commented Aug 3, 2024 •

edited

Loading

hua7450 commented Aug 6, 2024 •

edited

Loading

codecov bot commented Aug 13, 2024 •

edited

Loading

MaxGhenis Aug 21, 2024

hua7450 Aug 21, 2024

MaxGhenis Aug 21, 2024

MaxGhenis left a comment

MaxGhenis Aug 22, 2024

MaxGhenis Aug 22, 2024

	p_hud = parameters(period).gov.hud.ami_limit
	p = parameters(period).gov.hud.ami_limit

	size_limit.ESPECIALLY_LOW[size_capped_at_4]
	p.family_size.ESPECIALLY_LOW[size_capped_at_4]

Denver Property Tax Relief #4833

Denver Property Tax Relief #4833

Conversation

hua7450 commented Aug 3, 2024 • edited Loading

hua7450 commented Aug 6, 2024 • edited Loading

codecov bot commented Aug 13, 2024 • edited Loading

Codecov Report

MaxGhenis Aug 21, 2024

Choose a reason for hiding this comment

hua7450 Aug 21, 2024

Choose a reason for hiding this comment

MaxGhenis Aug 21, 2024

Choose a reason for hiding this comment

MaxGhenis left a comment

Choose a reason for hiding this comment

MaxGhenis Aug 22, 2024

Choose a reason for hiding this comment

MaxGhenis Aug 22, 2024

Choose a reason for hiding this comment

hua7450 commented Aug 3, 2024 •

edited

Loading

hua7450 commented Aug 6, 2024 •

edited

Loading

codecov bot commented Aug 13, 2024 •

edited

Loading