-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Denver Property Tax Relief #4833
Conversation
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/rate/homeowner.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/rate/renter.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/rate/renter.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/maximum_amount/renter.yaml
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782
This PR assigns the maximum values for households that are eligible for the program, following the methods used in Gary-Community-Ventures/benefits-api#461. |
policyengine_us/variables/gov/local/co/denver/property_tax_relief/denver_property_tax_relief.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/local/co/denver/property_tax_relief/denver_property_tax_relief.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/local/co/denver/property_tax_relief/denver_property_tax_relief.py
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/ami.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/rate/homeowner.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/rate/renter.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/rate/renter.yaml
Outdated
Show resolved
Hide resolved
...cyengine_us/parameters/gov/local/co/denver/property_tax_relief/maximum_amount/homeowner.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/maximum_amount/renter.yaml
Outdated
Show resolved
Hide resolved
...us/variables/gov/local/co/denver/property_tax_relief/denver_property_tax_relief_homeowner.py
Outdated
Show resolved
Hide resolved
...ne_us/variables/gov/local/co/denver/property_tax_relief/denver_property_tax_relief_renter.py
Outdated
Show resolved
Hide resolved
...local/co/denver/property_tax_relief/eligibility/co_de_property_tax_relief_renter_eligible.py
Outdated
Show resolved
Hide resolved
...local/co/denver/property_tax_relief/eligibility/co_de_property_tax_relief_renter_eligible.py
Outdated
Show resolved
Hide resolved
...al/co/denver/property_tax_relief/eligibility/co_de_property_tax_relief_homeowner_eligible.py
Outdated
Show resolved
Hide resolved
...ine_us/variables/gov/local/co/denver/property_tax_relief/co_de_property_tax_relief_renter.py
Outdated
Show resolved
Hide resolved
...ine_us/variables/gov/local/co/denver/property_tax_relief/co_de_property_tax_relief_renter.py
Outdated
Show resolved
Hide resolved
...ine_us/variables/gov/local/co/denver/property_tax_relief/co_de_property_tax_relief_renter.py
Outdated
Show resolved
Hide resolved
..._us/variables/gov/local/co/denver/property_tax_relief/co_de_property_tax_relief_homeowner.py
Outdated
Show resolved
Hide resolved
..._us/variables/gov/local/co/denver/property_tax_relief/co_de_property_tax_relief_homeowner.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/property_tax_relief/ami/rate/renter.yaml
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4833 +/- ##
========================================
Coverage 99.00% 99.01%
========================================
Files 2536 2555 +19
Lines 36845 37133 +288
Branches 152 158 +6
========================================
+ Hits 36479 36767 +288
Misses 337 337
Partials 29 29 ☔ View full report in Codecov by Sentry. |
policyengine_us/variables/household/income/household/household_state_benefits.py
Outdated
Show resolved
Hide resolved
...gine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/maximum_amount/homeowner.yaml
Outdated
Show resolved
Hide resolved
...gine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/maximum_amount/homeowner.yaml
Outdated
Show resolved
Hide resolved
...gine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/maximum_amount/homeowner.yaml
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782
policyengine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/ami/ami.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/ami/ami.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/ami/rate/homeowner.yaml
Outdated
Show resolved
Hide resolved
...variables/gov/local/co/denver/dhs/property_tax_relief/co_de_property_tax_relief_homeowner.py
Outdated
Show resolved
Hide resolved
...variables/gov/local/co/denver/dhs/property_tax_relief/co_de_property_tax_relief_homeowner.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/ami/rate/homeowner.yaml
Outdated
Show resolved
Hide resolved
...o/denver/dhs/property_tax_relief/eligibility/co_de_property_tax_relief_homeowner_eligible.py
Outdated
Show resolved
Hide resolved
...o/denver/dhs/property_tax_relief/eligibility/co_de_property_tax_relief_homeowner_eligible.py
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782
…engine-us into hua7450/issue4782
undo changes in reform folder
...ariables/gov/local/co/denver/dhs/property_tax_relief/co_denver_property_tax_relief_income.py
Outdated
Show resolved
Hide resolved
...nver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_homeowner_eligible.py
Outdated
Show resolved
Hide resolved
...nver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_homeowner_eligible.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/income.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/local/co/denver/dhs/property_tax_relief/income.yaml
Outdated
Show resolved
Hide resolved
.../denver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_renter_eligible.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/household/income/household/household_state_benefits.py
Outdated
Show resolved
Hide resolved
…" does not work and caused error
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782
...nver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_homeowner_eligible.py
Outdated
Show resolved
Hide resolved
.../denver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_renter_eligible.py
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782
policyengine_us/variables/gov/local/co/denver/dhs/is_co_denver_dhs_elderly.py
Outdated
Show resolved
Hide resolved
income = spm_unit("co_denver_property_tax_relief_income", period) | ||
size = spm_unit("spm_unit_size", period) | ||
ami = spm_unit.household("ami", period) | ||
p_hud = parameters(period).gov.hud.ami_limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we refactor the file this logic is from to avoid duplication? maybe create separate variables for each of the limits, and use the moderate one here? especially since also in the renter variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I combine those variables into one, like my current version? The downside of my current code is I have to input hud_income_level = MODERATE in test cases.
...nver/dhs/property_tax_relief/eligibility/co_denver_property_tax_relief_homeowner_eligible.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you refactor the original file? As is this duplicates much of the logic.
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4782
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final stretch here - we may want to refactor further to have the capped and excess size be their own variables (and making 4
a parameter) to reduce duplication, but this works for now
definition_period = YEAR | ||
|
||
def formula(spm_unit, period, parameters): | ||
p_hud = parameters(period).gov.hud.ami_limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p_hud = parameters(period).gov.hud.ami_limit | |
p = parameters(period).gov.hud.ami_limit |
size_exceeding_4 = max_(size - 4, 0) | ||
size_capped_at_4 = min_(size, 4) | ||
return ( | ||
size_limit.ESPECIALLY_LOW[size_capped_at_4] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for the excess and other files - in general please keep the p.
in where reasonable to indicate it's a parameter
size_limit.ESPECIALLY_LOW[size_capped_at_4] | |
p.family_size.ESPECIALLY_LOW[size_capped_at_4] |
Fixes #4782