Fix North Dakota marriage penalty credit parameters #4855
+23
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGhenis
changed the title
PavelMakarchuk
requested changes
Aug 10, 2024
policyengine_us/parameters/gov/states/nd/tax/income/credits/marriage_penalty/maximum.yaml
Show resolved
Hide resolved
policyengine_us/variables/gov/states/nd/tax/income/credits/nd_mpc.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4855 +/- ##
==========================================
+ Coverage 99.01% 99.02% +0.01%
==========================================
Files 2560 2575 +15
Lines 37217 37410 +193
Branches 159 159
==========================================
+ Hits 36851 37047 +196
+ Misses 337 334 -3
Partials 29 29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
could you add some unit test to nd_mpc.yaml and expalin in comments how you calculated the value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4653