-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix North Dakota marriage penalty credit parameters #4855
base: master
Are you sure you want to change the base?
Conversation
policyengine_us/parameters/gov/states/nd/tax/income/credits/marriage_penalty/maximum.yaml
Show resolved
Hide resolved
policyengine_us/variables/gov/states/nd/tax/income/credits/nd_mpc.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4855 +/- ##
==========================================
+ Coverage 99.01% 99.02% +0.01%
==========================================
Files 2560 2575 +15
Lines 37217 37410 +193
Branches 159 159
==========================================
+ Hits 36851 37047 +196
+ Misses 337 334 -3
Partials 29 29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add some unit test to nd_mpc.yaml
and expalin in comments how you calculated the value
Fixes #4653