Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nebraska Child Care Subsidy #4864

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Nebraska Child Care Subsidy #4864

wants to merge 19 commits into from

Conversation

vrathi101
Copy link
Collaborator

Fixes #4845

PavelMakarchuk
PavelMakarchuk requested changes Aug 15, 2024
View reviewed changes
policyengine_us/parameters/gov/states/ne/dhhs/child_care_subsidy/fpg_fraction.yaml Outdated Show resolved Hide resolved
...cyengine_us/parameters/gov/states/ne/dhhs/child_care_subsidy/special_need_age_threshold.yaml Outdated Show resolved Hide resolved
...yengine_us/variables/gov/states/ne/dhhs/child_care_subsidy/ne_child_care_subsidy_eligible.py Outdated Show resolved Hide resolved
policyengine_us/variables/household/demographic/person/is_student.py Outdated Show resolved Hide resolved
policyengine_us/variables/household/demographic/person/is_student.py Outdated Show resolved Hide resolved
policyengine_us/variables/household/demographic/person/has_special_needs.py Outdated Show resolved Hide resolved
policyengine_us/variables/household/demographic/person/goes_to_medical_or_therapy_visits.py Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (dbe7a06) to head (5603fbf).
Report is 11 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #4864    +/-   ##
========================================
  Coverage   99.01%   99.01%            
========================================
  Files        2560     2571    +11     
  Lines       37217    37345   +128     
  Branches      159      159            
========================================
+ Hits        36851    36979   +128     
  Misses        337      337            
  Partials       29       29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PavelMakarchuk
PavelMakarchuk requested changes Sep 5, 2024
View reviewed changes
...yengine_us/variables/gov/states/ne/dhhs/child_care_subsidy/ne_child_care_subsidy_eligible.py Outdated Show resolved Hide resolved
...yengine_us/variables/gov/states/ne/dhhs/child_care_subsidy/ne_child_care_subsidy_eligible.py Outdated Show resolved Hide resolved
...yengine_us/variables/gov/states/ne/dhhs/child_care_subsidy/ne_child_care_subsidy_eligible.py Show resolved Hide resolved
policyengine_us/variables/gov/states/ne/dhhs/child_care_subsidy/ne_child_care_subsidy.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/ne/dhhs/child_care_subsidy/ne_child_care_subsidy.py Show resolved Hide resolved
policyengine_us/variables/gov/states/ne/dhhs/child_care_subsidy/ne_child_care_subsidy.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/ne/dhhs/child_care_subsidy/ne_child_care_subsidy.py Outdated Show resolved Hide resolved
policyengine_us/variables/gov/states/ne/dhhs/child_care_subsidy/ne_child_care_subsidy.py Show resolved Hide resolved
policyengine_us/parameters/gov/states/ne/dhhs/child_care_subsidy/rate.yaml Outdated Show resolved Hide resolved
MaxGhenis
MaxGhenis requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also either add the redetermination logic here (by adding a new variable for whether they're currently enrolled, see other TANF programs) or file a separate issue for it

..._us/variables/gov/states/ne/dhhs/child_care_subsidy/ne_child_care_subsidy_income_eligible.py
period
).gov.states.ne.dhhs.child_care_subsidy.fpg_fraction
income = add(spm_unit, period, ["adjusted_gross_income"])
fpg = add(spm_unit, period, ["tax_unit_fpg"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right? This could differ from the sum of FPG across tax units in the SPM unit.

Suggested change
fpg = add(spm_unit, period, ["tax_unit_fpg"])
fpg = spm_unit("spm_unit_fpg", period)

policyengine_us/variables/gov/states/ne/dhhs/ne_dhhs_has_special_needs.py
reference = (
"https://dhhs.ne.gov/Documents/CC-Subsidy-Provider-Booklet.pdf#page=31",
"https://dhhs.ne.gov/licensure/Documents/CCC391-3.pdf#page=11",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's set this to is_disabled for now

policyengine_us/parameters/gov/states/ne/dhhs/child_care_subsidy/fpg_fraction/threshold.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename fee_free_limit

policyengine_us/parameters/gov/states/ne/dhhs/child_care_subsidy/fpg_fraction/maximum.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename initial_eligibility and clarify in label and description that this applies to initial eligibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGhenis MaxGhenis MaxGhenis requested changes

@PavelMakarchuk PavelMakarchuk PavelMakarchuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nebraska Child Care Subsidy
3 participants
@vrathi101 @MaxGhenis @PavelMakarchuk