Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massachusetts Emergency Aid to the Elderly, Disabled and Children (EAEDC) #4870

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

hua7450
Copy link
Collaborator

@hua7450 hua7450 commented Aug 14, 2024

Fixes #1712

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (f57467b) to head (2be6352).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4870      +/-   ##
==========================================
+ Coverage   99.00%   99.02%   +0.01%     
==========================================
  Files        2536     2572      +36     
  Lines       36845    37364     +519     
  Branches      152      158       +6     
==========================================
+ Hits        36479    36998     +519     
  Misses        337      337              
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hua7450 hua7450 marked this pull request as ready for review August 26, 2024 16:49
class ma_eaedc_disabled_earned_income(Variable):
value_type = float
entity = Person
label = "Massachusetts EAEDC disabled earned income"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label = "Massachusetts EAEDC disabled earned income"
label = "Massachusetts EAEDC earned income of a disabled person"

from policyengine_us.model_api import *


class ma_eaedc_total_earned_income(Variable):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class ma_eaedc_total_earned_income(Variable):
class ma_eaedc_no_disabled_earned_income(Variable):

from policyengine_us.model_api import *


class ma_eaedc_earned_income(Variable):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class ma_eaedc_earned_income(Variable):
class ma_eaedc_total_earned_income(Variable):

definition_period = YEAR
defined_for = StateCode.MA

adds = ["ma_eaedc_earned_income"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make a formula and lets do the same as in disabled income just with ~disabled & ~dependent

person = spm_unit.members
is_dependent = person("is_tax_unit_dependent", period)
age = person("age", period)
meets_age_limit = age < 18
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets parametrize this

value_type = bool
entity = SPMUnit
label = "Eligible for Massachusetts EAEDC dependent care deduction"
unit = USD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unit = USD

value_type = bool
entity = SPMUnit
label = "Disabled person's income eligible for Massachusetts EAEDC"
unit = USD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unit = USD

value_type = bool
entity = SPMUnit
label = "Assets eligible for Massachusetts EAEDC "
unit = USD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unit = USD

value_type = bool
entity = SPMUnit
label = "Age eligible for Massachusetts EAEDC "
unit = USD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unit = USD

defined_for = StateCode.MA

def formula(person, period, parameters):
disabled = person("is_disabled", period)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a is_dependent condition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Massachusetts Emergency Aid to the Elderly, Disabled and Children (EAEDC)
2 participants