change is_widowed to is_surviving_spouse #5108
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5108 +/- ##
==========================================
+ Coverage 99.01% 99.12% +0.11%
==========================================
Files 2560 2589 +29
Lines 37217 37671 +454
Branches 159 162 +3
==========================================
+ Hits 36851 37342 +491
+ Misses 337 297 -40
- Partials 29 32 +3 ☔ View full report in Codecov by Sentry. |
PavelMakarchuk
requested changes
Sep 24, 2024
There was a problem hiding this comment.
could you also change the corresponding tests?
For example surviving_spouse_eligible.yaml still uses is_widowed as an input
There was a problem hiding this comment.
You should be able to search in the codespace
There was a problem hiding this comment.
also label and documentation
MaxGhenis
requested changes
Dec 4, 2024
There was a problem hiding this comment.
also label and documentation
| is_widowed = person("is_widowed", period) | ||
| widowed_head = tax_unit.any(is_head & is_widowed) | ||
| is_surviving_spouse = person("is_surviving_spouse", period) | ||
| widowed_head = tax_unit.any(is_head & is_surviving_spouse) |
There was a problem hiding this comment.
and elsewhere
Suggested change
| widowed_head = tax_unit.any(is_head & is_surviving_spouse) | |
| surviving_spouse_head = tax_unit.any(is_head & is_surviving_spouse) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4710