-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial Rhode Island EITC refundability pre-2015 #5166
Open
YichunRen
wants to merge
8
commits into
PolicyEngine:master
Choose a base branch
from
YichunRen:YichunRen/issue5156
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
090b6dd
Remove CPS_2023
YichunRen 3ffbf04
update changelog
YichunRen e515abf
Merge branch 'master' of https://github.com/PolicyEngine/policyengine…
YichunRen 4421348
ri_refundable_eitc
YichunRen a36fb3c
Merge branch 'master' of https://github.com/PolicyEngine/policyengine…
YichunRen 5cc4fe2
add unit tests
YichunRen e6fac32
Merge branch 'master' of https://github.com/PolicyEngine/policyengine…
YichunRen 7c52776
use max_/min_
YichunRen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
- bump: minor | ||
changes: | ||
added: | ||
- Partial Rhode Island EITC refundability pre-2015 |
14 changes: 14 additions & 0 deletions
14
policyengine_us/parameters/gov/states/ri/tax/income/credits/eitc/refundable.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
description: Rhode Island provide this percent of refundable earned-income credit | ||
values: | ||
2011-01-01: 0.15 | ||
2015-01-01: 1 | ||
metadata: | ||
unit: /1 | ||
label: Rhode Island refundable EITC | ||
reference: | ||
- title: 44-30-2.6. Rhode Island taxable income — Rate of tax. (N)(2) | ||
href: https://webserver.rilegislature.gov/Statutes/TITLE44/44-30/44-I/44-30-2.6.htm | ||
- title: 2011 Form RI-1040 - RI SCHEDULE EIC | ||
href: https://tax.ri.gov/sites/g/files/xkgbur541/files/forms/2011/Income/2011-Resident-Booklet-FINAL.pdf#page=4 | ||
- title: 2015 Form RI-1040 - RI SCHEDULE EIC | ||
href: https://tax.ri.gov/sites/g/files/xkgbur541/files/forms/2015/Income/2015-1040_hhh.pdf#page=2 |
4 changes: 2 additions & 2 deletions
4
policyengine_us/parameters/gov/states/ri/tax/income/credits/refundable.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
...ne_us/tests/policy/baseline/gov/states/ri/tax/income/credits/eitc/ri_refundable_eitc.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
- name: 2014 Refundable EITC | ||
period: 2014 | ||
input: | ||
state_code: RI | ||
ri_eitc: 500 | ||
ri_income_tax_before_refundable_credits: 600 | ||
output: | ||
ri_refundable_eitc: 0 # 500 < 600 | ||
|
||
- name: 2014 Refundable EITC 2 | ||
period: 2014 | ||
input: | ||
state_code: RI | ||
ri_eitc: 600 | ||
ri_income_tax_before_refundable_credits: 500 | ||
output: | ||
ri_refundable_eitc: 15 #((600 - 500) * 0.15) | ||
|
||
- name: 2015 Refundable EITC | ||
period: 2015 | ||
input: | ||
state_code: RI | ||
ri_eitc: 500 | ||
ri_income_tax_before_refundable_credits: 600 | ||
output: | ||
ri_refundable_eitc: 0 # 500 < 600 | ||
|
||
- name: 2015 Refundable EITC 2 | ||
period: 2015 | ||
input: | ||
state_code: RI | ||
ri_eitc: 600 | ||
ri_income_tax_before_refundable_credits: 500 | ||
output: | ||
ri_refundable_eitc: 100 #((600 - 500) * 1) | ||
|
||
|
39 changes: 39 additions & 0 deletions
39
policyengine_us/variables/gov/states/ri/tax/income/credits/eitc/ri_refundable_eitc.py
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please take a look at the error in the test generated by this file. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
from policyengine_us.model_api import * | ||
|
||
|
||
class ri_refundable_eitc(Variable): | ||
value_type = float | ||
entity = TaxUnit | ||
label = "Rhode Island refundable earned income tax credit" | ||
unit = USD | ||
|
||
definition_period = YEAR | ||
reference = ( | ||
"https://tax.ri.gov/sites/g/files/xkgbur541/files/forms/2014/Income/2014-1040_h.pdf" # Calculation see RI SCHEDULE EIC | ||
"https://webserver.rilegislature.gov/Statutes/TITLE44/44-30/44-I/44-30-2.6.htm" | ||
) | ||
defined_for = StateCode.RI | ||
|
||
def formula(tax_unit, period, parameters): | ||
ri_eitc = tax_unit("ri_eitc", period) | ||
ri_income_tax_before_refundable_credits = tax_unit( | ||
"ri_income_tax_before_refundable_credits", period | ||
) | ||
p = parameters(period).gov.states.ri.tax.income.credits.eitc | ||
# refundable earned-income credit is the percent of the amount by which the Rhode Island earned-income credit exceeds the Rhode Island income tax. | ||
return max( | ||
0, | ||
p.refundable | ||
* ( | ||
ri_eitc - min(ri_eitc, ri_income_tax_before_refundable_credits) | ||
), | ||
) | ||
YichunRen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# | ||
# return max( | ||
# 0, | ||
# p.refundable | ||
# * ( | ||
# ri_eitc - min(ri_eitc, ri_income_tax_before_refundable_credits) | ||
# ), | ||
# ) + min(ri_eitc, ri_income_tax_before_refundable_credits) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the structure changed post-2015 - would be need a new bool parameter to indicate that (we want the current EITC calculation to apply post 2015
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has been no structural change before or after 2015. Before 2015, the rate was 15%, and now it has increased to 100%. See (N) (2) in https://webserver.rilegislature.gov/Statutes/TITLE44/44-30/44-I/44-30-2.6.htm