Refactor the Missouri income tax parameter structure #5255

leehengpan · 2024-10-19T21:58:42Z

New PR to replace PR #5236

codecov · 2024-10-19T22:36:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (cb92a56) to head (8b8c519).
Report is 116 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5255      +/-   ##
==========================================
- Coverage   99.12%   99.00%   -0.13%     
==========================================
  Files        2592     2613      +21     
  Lines       37707    38056     +349     
  Branches      162      165       +3     
==========================================
+ Hits        37378    37677     +299     
- Misses        297      346      +49     
- Partials       32       33       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

changelog.yaml

changelog_entry.yaml

PavelMakarchuk · 2024-10-22T05:10:24Z

...s/parameters/gov/states/mo/tax/income/deductions/mo_private_pension_deduction_allowance.yaml

Please rename all of these parameter files to remove the mo_
Also please structure them into folders based on program

this will have an effect on the variables - please run the MO tests when adjustments are made and adjust code as needed

PavelMakarchuk · 2024-10-22T05:10:49Z

...e_us/parameters/gov/states/mo/tax/income/credits/property_tax/income_offset/joint_owner.yaml

make a folder for joint and name the tow files
owner.yaml
renter.yaml

PavelMakarchuk · 2024-10-22T05:11:11Z

...yengine_us/parameters/gov/states/mo/tax/income/credits/property_tax/phase_out/threshold.yaml

rename to income_threshold.yaml

PavelMakarchuk · 2024-10-24T03:43:57Z

Please make sure that the variable structure is adjusted

PavelMakarchuk

minor changes

...ine_us/parameters/gov/states/mo/tax/income/credits/property_tax/rent_property_tax_limit.yaml

policyengine_us/parameters/gov/states/mo/tax/income/deductions/federal_income_tax/cap.yaml

...rameters/gov/states/mo/tax/income/deductions/pension/public_pension_deduction_allowance.yaml

policyengine_us/parameters/gov/states/mo/tax/income/credits/property_tax/age_threshold.yaml

...e_us/parameters/gov/states/mo/tax/income/credits/property_tax/income_offset/joint/owner.yaml

...ngine_us/parameters/gov/states/mo/tax/income/credits/property_tax/aged_survivor_min_age.yaml

hua7450 · 2024-10-29T14:29:24Z

policyengine_us/parameters/gov/states/mo/tax/income/credits/property_tax/age_threshold.yaml

description: Missouri limits the property tax credit to filers of this age or older.

hua7450 · 2024-10-29T14:36:28Z

...ngine_us/parameters/gov/states/mo/tax/income/credits/property_tax/aged_survivor_min_age.yaml

description: Missouri limits the property tax credit to filers receiving social security survivor benefits who are at least this age.

hua7450 · 2024-10-29T14:38:26Z

policyengine_us/parameters/gov/states/mo/tax/income/credits/property_tax/cap.yaml

description: Missouri caps the property tax credit for a rented property to this amount.

hua7450 · 2024-10-29T14:41:13Z

For all parameter files, if there is a "MO" in description, replace it with "Missouri", and rephrase the description.
Under the references section, I would keep the MO in things like 2023 Form MO-1040, because that is the tax form's name.

…operty_tax/age_threshold.yaml Co-authored-by: hua7450 <[email protected]>

…operty_tax/income_offset/joint/owner.yaml Co-authored-by: hua7450 <[email protected]>

…operty_tax/aged_survivor_min_age.yaml Co-authored-by: hua7450 <[email protected]>

…e-us into issue5211

hua7450 · 2024-10-31T13:47:51Z

Can you add the specific legal code section to all parameter references?

leehengpan · 2024-11-01T17:10:53Z

Can you add the specific legal code section to all parameter references?

Could you give an example of how to do this since I have little idea of where I should look for these section codes. Thanks

hua7450 · 2024-11-01T17:45:28Z

...cyengine_us/parameters/gov/states/mo/tax/income/credits/property_tax/property_tax_limit.yaml

@@ -10,5 +10,5 @@ metadata:
      href: https://dor.mo.gov/forms/MO-PTS_2023.pdf#page=2
    - title: 2021 MO-PTS Property Tax Credit Schedule, Line 11
      href: https://dor.mo.gov/forms/MO-PTS_2021.pdf#page=2
-    - title: MO Rev 135.025
+    - title: Revisor of Missouri Title X TAXATION AND REVENUE Chapter 135.025


Suggested change

- title: Revisor of Missouri Title X TAXATION AND REVENUE Chapter 135.025

- title: Missouri Rev 135.025 (2)

For example, the value 1100 appears in section 2 of the link. Therefore we add (2) at the end of the title. If the value appears in section 1 part 2, then it is Missouri Rev 135.025 (1)(2)

hua7450 · 2024-11-01T17:54:50Z

policyengine_us/parameters/gov/states/mo/tax/income/credits/property_tax/cap.yaml

@@ -10,5 +10,5 @@ metadata:
      href: https://dor.mo.gov/forms/MO-PTS_2023.pdf#page=2
    - title: 2021 MO-PTS Property Tax Credit Schedule, Line 12
      href: https://dor.mo.gov/forms/MO-PTS_2021.pdf#page=2
-    - title: MO Rev 135.025
+    - title: Revisor of Missouri Title X TAXATION AND REVENUE Chapter 135.025


Suggested change

- title: Revisor of Missouri Title X TAXATION AND REVENUE Chapter 135.025

- title: Missouri Rev 135.025

If the legal code has no sub-section like this one, you don't need to add anything.

leehengpan and others added 4 commits October 19, 2024 17:44

Update minimum_taxable_income.yaml

2d494eb

Removing state code from titles

df6bfae

Update changelog

f47d9a8

Merge branch 'master' into issue5211

c74713f

leehengpan self-assigned this Oct 20, 2024

PavelMakarchuk reviewed Oct 21, 2024

View reviewed changes

changelog.yaml Outdated Show resolved Hide resolved

Update changelog to changelog_entry.yaml

c8c128b

PavelMakarchuk reviewed Oct 21, 2024

View reviewed changes

changelog_entry.yaml Outdated Show resolved Hide resolved

PavelMakarchuk reviewed Oct 21, 2024

View reviewed changes

changelog_entry.yaml Outdated Show resolved Hide resolved

remove date from changelog

63fd928

PavelMakarchuk requested changes Oct 22, 2024

View reviewed changes

PavelMakarchuk marked this pull request as draft October 22, 2024 05:16

Restructure and rename files

2bf18f2

Restructure variables

0ce3ec2

PavelMakarchuk requested changes Oct 28, 2024

View reviewed changes

PavelMakarchuk requested a review from hua7450 October 29, 2024 12:37

minor changes

5fcd686

hua7450 reviewed Oct 29, 2024

View reviewed changes

policyengine_us/parameters/gov/states/mo/tax/income/credits/property_tax/age_threshold.yaml Outdated Show resolved Hide resolved

hua7450 reviewed Oct 29, 2024

View reviewed changes

...e_us/parameters/gov/states/mo/tax/income/credits/property_tax/income_offset/joint/owner.yaml Outdated Show resolved Hide resolved

hua7450 reviewed Oct 29, 2024

View reviewed changes

...ngine_us/parameters/gov/states/mo/tax/income/credits/property_tax/aged_survivor_min_age.yaml Outdated Show resolved Hide resolved

hua7450 reviewed Oct 29, 2024

View reviewed changes

leehengpan and others added 4 commits October 29, 2024 11:01

Update policyengine_us/parameters/gov/states/mo/tax/income/credits/pr…

6440fbb

…operty_tax/age_threshold.yaml Co-authored-by: hua7450 <[email protected]>

Update policyengine_us/parameters/gov/states/mo/tax/income/credits/pr…

716aeb9

…operty_tax/income_offset/joint/owner.yaml Co-authored-by: hua7450 <[email protected]>

Update policyengine_us/parameters/gov/states/mo/tax/income/credits/pr…

3ee81b9

…operty_tax/aged_survivor_min_age.yaml Co-authored-by: hua7450 <[email protected]>

rephrase description

c1e0df4

Merge branch 'issue5211' of https://github.com/leehengpan/policyengin…

402166d

…e-us into issue5211

Fix descriptions, titles and form names in reference

8b8c519

leehengpan requested a review from hua7450 November 1, 2024 17:15

hua7450 reviewed Nov 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor the Missouri income tax parameter structure #5255

Refactor the Missouri income tax parameter structure #5255

leehengpan commented Oct 19, 2024 •

edited

Loading

codecov bot commented Oct 19, 2024 •

edited

Loading

PavelMakarchuk Oct 22, 2024

PavelMakarchuk Oct 22, 2024

PavelMakarchuk Oct 22, 2024

PavelMakarchuk commented Oct 24, 2024

PavelMakarchuk left a comment

hua7450 Oct 29, 2024

hua7450 Oct 29, 2024

hua7450 Oct 29, 2024

hua7450 commented Oct 29, 2024 •

edited

Loading

hua7450 commented Oct 31, 2024

leehengpan commented Nov 1, 2024

hua7450 Nov 1, 2024

leehengpan Nov 1, 2024

hua7450 Nov 1, 2024

leehengpan Nov 1, 2024

	- title: Revisor of Missouri Title X TAXATION AND REVENUE Chapter 135.025
	- title: Missouri Rev 135.025 (2)

	- title: Revisor of Missouri Title X TAXATION AND REVENUE Chapter 135.025
	- title: Missouri Rev 135.025

Refactor the Missouri income tax parameter structure #5255

Are you sure you want to change the base?

Refactor the Missouri income tax parameter structure #5255

Conversation

leehengpan commented Oct 19, 2024 • edited Loading

codecov bot commented Oct 19, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PavelMakarchuk commented Oct 24, 2024

PavelMakarchuk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hua7450 commented Oct 29, 2024 • edited Loading

hua7450 commented Oct 31, 2024

leehengpan commented Nov 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leehengpan commented Oct 19, 2024 •

edited

Loading

codecov bot commented Oct 19, 2024 •

edited

Loading

hua7450 commented Oct 29, 2024 •

edited

Loading