Alter VA reduced itemized deductions based on changes to TCJA #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5279
Virginia follows pre-TCJA tax policy, but does not follow its removal of two tax parameters. To keep Virginia calculations in line with federal policy (minus TCJA), we previously hardcoded a method of determining the value of these parameters based on date. However, TCJA extension policies that set these params to
infin order to simulate continued nullification of said params were not properly handled by the hardcoded date, causingNaNissues for certain calculations that then crashed the front end.This PR attempts to better represent Virginia's response to the TCJA by instead taking the standard federal params and filtering
infvalues out. In this way, we create two custom internal parameters that track the federal ones, but aren't explicitly tied to them.This PR also adds a test for one of the offending years, 2027, to ensure that the changes work properly.