Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create phaseout for NYC school credit for NYC CTC proposal #5510

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Create phaseout for NYC school credit for NYC CTC proposal #5510

merged 6 commits into from
Jan 27, 2025

Conversation

PavelMakarchuk
Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk commented Jan 24, 2025 •
edited
Loading

Fixes #5509

@PavelMakarchuk PavelMakarchuk changed the title Include the New York 2025 inflation rebate in the net income tree Create phaseout for NYC school credit for NYC CTC proposal Jan 24, 2025
MaxGhenis
MaxGhenis requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename and update comments to clarify joint includes surviving spouse. Surviving spouse is more like a head of household filing status (you need a dependent) than joint, so this connection is not obvious.

Please also leave a docstring in the variable folder naming and linking to the bill.

MaxGhenis
MaxGhenis reviewed Jan 26, 2025
View reviewed changes
policyengine_us/reforms/local/nyc/stc/phase_out/nyc_school_tax_credit_with_phase_out.py Outdated
"""
Calculates the phase-out amount for the NYC School Tax Credit.

Args:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant a file-level docstring explaining the policy. These args do not match the formula args.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a readme instead

@MaxGhenis MaxGhenis merged commit 0900111 into master Jan 27, 2025
3 checks passed
@MaxGhenis MaxGhenis deleted the PavelMakarchuk/issue5507 branch January 27, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daphnehanse11 daphnehanse11 daphnehanse11 approved these changes

@MaxGhenis MaxGhenis MaxGhenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create phaseout for NYC school credit for NYC CTC proposal
3 participants
@PavelMakarchuk @MaxGhenis @daphnehanse11