add --hash-by-class #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert True | ||
|
|
||
| class TC2(unittest.TestCase): |
There was a problem hiding this comment.
I changed TC2 and TC3 to not inherit from TC1 to avoid inheriting parent test methods.
|
Hm. I just tried this on our test suite and it missed some classes. |
|
Hah, I get different results locally compared to our ci cluster. I'll reopen. |
|
Oops, that was just me being a dingus 😁 Ready for review. |
I hadn't seen that before either. Nice. |
simon-weber
force-pushed
the
class_distribution
branch
from
9278d13
to
e7c53fb
Compare
|
Would you mind updating the README to document this new option? |
|
Good call; will do. |
|
👍 updated the readme |
|
bump 😁 |
|
Looks great! Thanks again, Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2.
(This is the first time I've used
PluginTester-- it's pretty nifty! You might want to refactor your other tests to use it).