Skip to content

Commit

Permalink
Disable test because of flakyness (apache#45947)
Browse files Browse the repository at this point in the history
  • Loading branch information
vincbeck authored Jan 23, 2025
1 parent 56bf75d commit c092d44
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 0 additions & 4 deletions airflow/auth/managers/simple/views/auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

from urllib.parse import parse_qsl, urlencode, urlsplit, urlunsplit

import pytest
from flask import redirect, request, session, url_for
from flask_appbuilder import expose

Expand Down Expand Up @@ -64,9 +63,6 @@ def logout(self):
session.clear()
return redirect(url_for("SimpleAuthManagerAuthenticationViews.login"))

@pytest.mark.skip(
"This test will be deleted soon, meanwhile disabling it because it is flaky. See: https://github.com/apache/airflow/issues/45818"
)
@csrf.exempt
@expose("/login_submit", methods=("GET", "POST"))
def login_submit(self):
Expand Down
3 changes: 3 additions & 0 deletions tests/auth/managers/simple/views/test_auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ def test_logout_redirects_to_login_and_clear_user(self, simple_app):
assert response.location == "/login"
assert session.get("user") is None

@pytest.mark.skip(
"This test will be deleted soon, meanwhile disabling it because it is flaky. See: https://github.com/apache/airflow/issues/45818"
)
@pytest.mark.parametrize(
"username, password, is_successful, query_params, expected_redirect",
[
Expand Down

0 comments on commit c092d44

Please sign in to comment.