WETH Oracle support #429
Open
WETH Oracle support #429
+116
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
JuaniRios
force-pushed
the
11-29-weth_oracle_support
branch
2 times, most recently
from
8fa2387 to
8f06f16
Compare
JuaniRios
force-pushed
the
11-29-weth_oracle_support
branch
from
8f06f16 to
aec984b
Compare
This was referenced Dec 4, 2024
vstam1
reviewed
Dec 11, 2024
| @@ -179,7 +179,7 @@ std = [ | |||
| "sp-block-builder/std", | |||
| "sp-consensus-aura/std", | |||
| "sp-core/std", | |||
| # "sp-debug-derive/std", | |||
| "sp-debug-derive/std", | |||
There was a problem hiding this comment.
Should this be included again?
| @@ -28,7 +28,7 @@ scale-info = { workspace= true, default-features = false, features = [ | |||
| lazy_static = "1.5.0" | |||
|
|
|||
| # Uncomment this and the std feature below to see variables instead of <wasm:stripped> in the console output | |||
| #sp-debug-derive = { workspace = true, features = ["force-debug"]} | |||
| sp-debug-derive = { workspace = true, features = ["force-debug"]} | |||
| frame_metadata_hash_extension::CheckMetadataHash::<Runtime>::new(true), | ||
| #[cfg(not(feature = "metadata-hash"))] |
There was a problem hiding this comment.
How exactly does this work with metadata-hash? Shouldn't we always build the runtime with the new CheckmetadataHash? Was this only for testing purposes?
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing?