Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WETH from AssetHub support #427

Merged
merged 1 commit into from
Jan 16, 2025
Merged

WETH from AssetHub support #427

merged 1 commit into from
Jan 16, 2025

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Oct 31, 2024 •
edited
Loading

What?

Add WETH from AssetHub as an AcceptedFundingAsset

How?

  • Add new enum variant
  • Add asset multilocation to xcm filter

Testing?

  • wap_from_different_funding_assets modified to add WETH

Anything Else?

We are missing the following PRs before we can release this feature:

  • Integration test with chopsticks
  • Price fetcher with the oracle

This was referenced Oct 31, 2024
Merged
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Oct 31, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JuaniRios JuaniRios mentioned this pull request Oct 31, 2024
Merged
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch 4 times, most recently from 15a3d31 to 35e2967 Compare November 6, 2024 09:32
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 663d2eb to e970b74 Compare November 27, 2024 13:30
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch from 35e2967 to dcffaf8 Compare November 27, 2024 13:30
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from e970b74 to 8684d26 Compare November 27, 2024 15:56
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch from dcffaf8 to 94c162a Compare November 27, 2024 15:56
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 8684d26 to 1febc0a Compare November 28, 2024 11:49
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch from 94c162a to 232251f Compare November 28, 2024 11:49
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 1febc0a to 926ce50 Compare November 28, 2024 11:53
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch from 232251f to de657df Compare November 28, 2024 11:53
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 926ce50 to e894641 Compare November 28, 2024 12:06
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch 3 times, most recently from ea173c0 to e296ce7 Compare November 29, 2024 13:23
@JuaniRios JuaniRios requested review from lrazovic and vstam1 November 29, 2024 13:29
@JuaniRios JuaniRios self-assigned this Nov 29, 2024
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch from e296ce7 to dca7f69 Compare November 29, 2024 13:34
@JuaniRios JuaniRios marked this pull request as ready for review November 29, 2024 13:35
@JuaniRios JuaniRios changed the title WETH from assethub support WETH from AssetHub support Nov 29, 2024
This was referenced Nov 29, 2024
Merged
Merged
This was referenced Dec 9, 2024
Draft
Merged
@JuaniRios JuaniRios mentioned this pull request Dec 19, 2024
Merged
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from e894641 to b47e7f2 Compare December 20, 2024 13:49
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch from dca7f69 to 1f9f698 Compare December 20, 2024 13:49
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from b47e7f2 to 615e0c8 Compare January 10, 2025 11:49
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch from 1f9f698 to 7dbc64e Compare January 10, 2025 11:49
@lrazovic lrazovic force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 615e0c8 to 0217600 Compare January 15, 2025 13:00
@lrazovic lrazovic force-pushed the 10-31-weth_from_assethub_support branch from 7dbc64e to bc9e543 Compare January 15, 2025 13:00
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 0217600 to 615e0c8 Compare January 15, 2025 13:03
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch from bc9e543 to 7dbc64e Compare January 15, 2025 13:03
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 615e0c8 to f53d335 Compare January 16, 2025 09:47
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch from 7dbc64e to f586fde Compare January 16, 2025 09:47
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from f53d335 to c44cce6 Compare January 16, 2025 10:27
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch from f586fde to d33ed15 Compare January 16, 2025 10:27
@JuaniRios JuaniRios mentioned this pull request Jan 16, 2025
Open
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jan 16, 2025 •
edited
Loading

Merge activity

  • Jan 16, 7:09 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 16, 7:17 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 16, 7:18 AM EST: A user merged this pull request with Graphite.
  • Jan 16, 7:18 AM EST: Graphite couldn't merge this PR because it failed for an unknown reason.

@JuaniRios JuaniRios changed the base branch from 10-30-set_round_end_block_to_none_on_evaluation_fail to graphite-base/427 January 16, 2025 12:13
@JuaniRios JuaniRios changed the base branch from graphite-base/427 to main January 16, 2025 12:15
@JuaniRios JuaniRios force-pushed the 10-31-weth_from_assethub_support branch from d33ed15 to dd14832 Compare January 16, 2025 12:16
@JuaniRios JuaniRios merged commit b413486 into main Jan 16, 2025
1 check passed
@JuaniRios JuaniRios deleted the 10-31-weth_from_assethub_support branch January 16, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 Awaiting requested review from vstam1

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic