Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssetId Storage Migration #434

Merged
merged 1 commit into from
Jan 16, 2025
Merged

AssetId Storage Migration #434

merged 1 commit into from
Jan 16, 2025

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Dec 19, 2024 •
edited
Loading

What?

Migrate all storage that mentioned u32 asset id to a Location

Why?

Previous PR changed this

How?

Its technically a new storage item since the asset id was used as a key, so we delete the old storage and create a new one for each item.

Testing?

we did a manual override with chopsticks and a try-runtime run and it worked.

This was referenced Dec 19, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Draft
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Dec 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JuaniRios JuaniRios mentioned this pull request Dec 19, 2024
Merged
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from 6a91141 to 1278fab Compare December 20, 2024 13:49
@JuaniRios JuaniRios force-pushed the 12-19-assetid_storage_migration branch 2 times, most recently from 22ae1dc to 08830b9 Compare December 20, 2024 18:16
@JuaniRios JuaniRios force-pushed the 12-19-assetid_storage_migration branch 2 times, most recently from b19abfc to 45e1c92 Compare January 6, 2025 12:55
@JuaniRios JuaniRios self-assigned this Jan 6, 2025
@JuaniRios JuaniRios requested a review from lrazovic January 6, 2025 13:10
@JuaniRios JuaniRios marked this pull request as ready for review January 6, 2025 13:11
@JuaniRios JuaniRios force-pushed the 12-19-assetid_storage_migration branch 2 times, most recently from 668d289 to 5f4d592 Compare January 6, 2025 13:56
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from 1278fab to 62e8291 Compare January 10, 2025 11:50
@JuaniRios JuaniRios force-pushed the 12-19-assetid_storage_migration branch from 5f4d592 to c3c3889 Compare January 10, 2025 11:50
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from 62e8291 to c88d1c7 Compare January 10, 2025 14:29
@JuaniRios JuaniRios force-pushed the 12-19-assetid_storage_migration branch from c3c3889 to 2ba2af7 Compare January 10, 2025 14:29
@lrazovic lrazovic force-pushed the 12-11-fix_fungibles_api branch from c88d1c7 to 42e832c Compare January 15, 2025 13:00
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from 42e832c to c88d1c7 Compare January 15, 2025 13:03
@JuaniRios JuaniRios force-pushed the 12-19-assetid_storage_migration branch from 4908e34 to 8f2b9ae Compare January 15, 2025 13:04
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from c88d1c7 to 8bcb321 Compare January 16, 2025 09:47
@JuaniRios JuaniRios force-pushed the 12-19-assetid_storage_migration branch from 8f2b9ae to 9be5f16 Compare January 16, 2025 09:47
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from 8bcb321 to 21cd51a Compare January 16, 2025 10:27
@JuaniRios JuaniRios force-pushed the 12-19-assetid_storage_migration branch from 9be5f16 to 3e9a423 Compare January 16, 2025 10:27
@JuaniRios JuaniRios mentioned this pull request Jan 16, 2025
Open
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jan 16, 2025 •
edited
Loading

Merge activity

  • Jan 16, 7:09 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 16, 7:18 AM EST: Graphite couldn't merge this pull request because a downstack PR WETH from AssetHub support #427 failed to merge.
  • Jan 16, 7:30 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 16, 7:35 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 16, 7:36 AM EST: A user merged this pull request with Graphite.
  • Jan 16, 7:36 AM EST: Graphite couldn't merge this PR because it failed for an unknown reason.

@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from 21cd51a to c51fd70 Compare January 16, 2025 12:24
@JuaniRios JuaniRios force-pushed the 12-19-assetid_storage_migration branch from 3e9a423 to fa1def0 Compare January 16, 2025 12:24
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from c51fd70 to 43e9d12 Compare January 16, 2025 12:29
@JuaniRios JuaniRios force-pushed the 12-19-assetid_storage_migration branch from fa1def0 to 28ac5db Compare January 16, 2025 12:29
@JuaniRios JuaniRios changed the base branch from 12-11-fix_fungibles_api to graphite-base/434 January 16, 2025 12:31
@JuaniRios JuaniRios changed the base branch from graphite-base/434 to main January 16, 2025 12:33
@JuaniRios JuaniRios force-pushed the 12-19-assetid_storage_migration branch from 28ac5db to 2f3a7e0 Compare January 16, 2025 12:34
@JuaniRios JuaniRios merged commit ef3dc1b into main Jan 16, 2025
1 check passed
@JuaniRios JuaniRios deleted the 12-19-assetid_storage_migration branch January 16, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic