Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚮 Remove WAP #449

Open
wants to merge 1 commit into
base: 02-05-auction_round_improvements
Choose a base branch
from
Open

🚮 Remove WAP #449

wants to merge 1 commit into from
+188 −1,060

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Feb 6, 2025 •
edited
Loading

What?

  • Remove the WAP
  • Accepted bids don't get any refund since there's no difference between price paid and final price.
  • Only Partially accepted bids get some refund
  • Rejected bids still get full refund

Why?

  • No contribution round to profit from the WAP, so only thing we're doing is making the system more confusing and giving less funds to the issuer.

How?

  • Remove all references to the WAP
  • Don't give refunds based on the price difference

Testing?

  • Delete WAP related tests
  • Amend the other tests

@JuaniRios JuaniRios mentioned this pull request Feb 6, 2025
Open
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Feb 6, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JuaniRios JuaniRios mentioned this pull request Feb 6, 2025
Open
@JuaniRios JuaniRios force-pushed the 02-06-remove_wap branch 3 times, most recently from 1407909 to bb04b5f Compare February 6, 2025 13:54
@JuaniRios JuaniRios changed the title Remove WAP 🚮 Remove WAP Feb 6, 2025
@JuaniRios JuaniRios self-assigned this Feb 6, 2025
@JuaniRios JuaniRios requested a review from lrazovic February 6, 2025 14:16
@JuaniRios JuaniRios marked this pull request as ready for review February 6, 2025 14:18
@JuaniRios JuaniRios mentioned this pull request Feb 7, 2025
Open
@JuaniRios JuaniRios force-pushed the 02-05-auction_round_improvements branch from ede7645 to 9686d17 Compare February 11, 2025 13:26
@lrazovic lrazovic force-pushed the 02-05-auction_round_improvements branch from 9686d17 to 21220b2 Compare February 11, 2025 14:37
@lrazovic lrazovic force-pushed the 02-05-auction_round_improvements branch from 21220b2 to d5880dd Compare February 11, 2025 14:39
@JuaniRios JuaniRios force-pushed the 02-05-auction_round_improvements branch from d5880dd to ec99d8a Compare February 12, 2025 12:15
This was referenced Feb 12, 2025
Closed
Closed
Open
@JuaniRios JuaniRios force-pushed the 02-05-auction_round_improvements branch from ec99d8a to e499ad2 Compare February 13, 2025 14:50
@JuaniRios JuaniRios force-pushed the 02-06-remove_wap branch 2 times, most recently from 00f0646 to 71f5d5e Compare February 13, 2025 16:44
@JuaniRios JuaniRios force-pushed the 02-05-auction_round_improvements branch from 18720a2 to b44dd90 Compare February 17, 2025 09:46
This was referenced Feb 17, 2025
Open
Open
Closed
Open
Open
This was referenced Feb 24, 2025
Closed
Open
@lrazovic lrazovic force-pushed the 02-05-auction_round_improvements branch from b44dd90 to 3d5992e Compare February 27, 2025 13:14
@lrazovic lrazovic mentioned this pull request Feb 27, 2025
Open
This was referenced Mar 3, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic