🗑️ Remove contribution/remainder leftovers #458
+38
−312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
JuaniRios
changed the base branch from
02-17-plmc_ah_transfer_test
to
graphite-base/458
JuaniRios
force-pushed
the
02-20-remove_contribution_remainder_leftovers
branch
from
f560133 to
0394eca
Compare
lrazovic
force-pushed
the
02-20-remove_contribution_remainder_leftovers
branch
from
0394eca to
c121786
Compare
lrazovic
force-pushed
the
new-weights
branch
from
26c4b6c to
654ba18
Compare
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (02/28/25)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
lrazovic
approved these changes
Mar 3, 2025
This was referenced Mar 3, 2025
lrazovic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pull request includes several changes to the
pallets/fundingmodule and related files, focusing on simplifying the codebase and updating documentation. The most important changes include the removal of unused structures, updates to the README file, and minor code cleanups.Documentation updates:
pallets/funding/README.md: Updated the README to provide a more concise and clear explanation of the funding process, removing outdated information and adding new sections to describe the updated project lifecycle.Codebase simplification:
pallets/funding/src/instantiator/types.rs: Removed theTestProjectParamsandContributionParamsstructures along with their associated implementations and traits. This cleanup helps in reducing unnecessary code. [1] [2]pallets/funding/src/lib.rs: Removed theContributionInfoOftype alias and theContributionevent variant, as they are no longer needed. This simplifies the event handling and type definitions. [1] [2]Minor code cleanup:
integration-tests/chopsticks/src/transfers/PolimecToHub.ts: Added a blank line for better readability in thePolimecToHubTransferclass.pallets/funding/src/lib.rs: Cleaned up comments related to user roles and project lifecycle to improve clarity.