Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneeded TODO removal #392

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Unneeded TODO removal #392

merged 1 commit into from
Sep 12, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Sep 3, 2024

What?

  • Todo in linear release pallet was awaiting a hold reason check.

Why?

  • We don't need it because if the 2 indexes declared don't exist for that hold reason then we will just get an error.

Copy link

graphite-app bot commented Sep 3, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (09/03/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from 698bf3c to 7e35b82 Compare September 3, 2024 13:20
@JuaniRios JuaniRios force-pushed the 09-03-unneeded_todo_removal branch from e1f62fe to d85ba33 Compare September 3, 2024 13:20
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from 7e35b82 to ced692f Compare September 3, 2024 14:06
@JuaniRios JuaniRios force-pushed the 09-03-unneeded_todo_removal branch from d85ba33 to d9f280d Compare September 3, 2024 14:06
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from ced692f to e243ba0 Compare September 3, 2024 14:19
@JuaniRios JuaniRios force-pushed the 09-03-unneeded_todo_removal branch from d9f280d to 1c0dce8 Compare September 3, 2024 14:19
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from e243ba0 to 70d869b Compare September 3, 2024 14:29
@JuaniRios JuaniRios force-pushed the 09-03-unneeded_todo_removal branch from 1c0dce8 to 270fcfe Compare September 3, 2024 14:29
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from 70d869b to 54a468b Compare September 3, 2024 14:37
@JuaniRios JuaniRios force-pushed the 09-03-unneeded_todo_removal branch from 270fcfe to 75d0fca Compare September 3, 2024 14:38
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from 54a468b to fb4ff1a Compare September 4, 2024 13:07
@JuaniRios JuaniRios force-pushed the 09-03-unneeded_todo_removal branch from 75d0fca to 89f5ecb Compare September 4, 2024 13:07
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from fb4ff1a to 2229b2d Compare September 9, 2024 11:10
@JuaniRios JuaniRios force-pushed the 09-03-unneeded_todo_removal branch from 89f5ecb to c5cf0b7 Compare September 9, 2024 11:10
@JuaniRios JuaniRios mentioned this pull request Sep 9, 2024
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch 2 times, most recently from a3347fa to 8448527 Compare September 10, 2024 08:41
@JuaniRios JuaniRios force-pushed the 09-03-unneeded_todo_removal branch from c5cf0b7 to df36f08 Compare September 10, 2024 08:41
@lrazovic lrazovic force-pushed the 09-03-unneeded_todo_removal branch from df36f08 to e3a3c3d Compare September 10, 2024 13:45
@JuaniRios JuaniRios force-pushed the 09-03-unneeded_todo_removal branch from e3a3c3d to dcf81c2 Compare September 11, 2024 11:15
Copy link
Contributor Author

JuaniRios commented Sep 12, 2024

Merge activity

  • Sep 12, 9:39 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Sep 12, 9:41 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 12, 9:42 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 09-03-linear_release_merging_schedules to graphite-base/392 September 12, 2024 13:39
@JuaniRios JuaniRios changed the base branch from graphite-base/392 to main September 12, 2024 13:40
@JuaniRios JuaniRios force-pushed the 09-03-unneeded_todo_removal branch from dcf81c2 to d365a13 Compare September 12, 2024 13:40
@JuaniRios JuaniRios merged commit e93fa7e into main Sep 12, 2024
@JuaniRios JuaniRios deleted the 09-03-unneeded_todo_removal branch September 12, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants