Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Switch to MultiLocation in the SignedExtension #406

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Oct 4, 2024

What?

  • Make our Asset fee-paying Signed Extension compatible with @polkadot/api JS packages.

Why?

  • The @polkadot/api JS packages work better if the assetId is a MultiLocation/Location, so our initial u32 based solution didn't work

How?

  • Make the signed extension accept a xcm::v3::MultiLocation, and convert it internally to a u32.

@JuaniRios JuaniRios mentioned this pull request Oct 4, 2024
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 20d1727 to 7bcdb3c Compare October 4, 2024 09:50
@JuaniRios JuaniRios force-pushed the 09-25-new_e2e_tests branch from d099958 to 8b19fd8 Compare October 4, 2024 10:32
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 7bcdb3c to 126d1db Compare October 4, 2024 10:32
@JuaniRios JuaniRios force-pushed the 09-25-new_e2e_tests branch from 8b19fd8 to a9bd91b Compare October 4, 2024 12:17
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 126d1db to 647e303 Compare October 4, 2024 12:18
@JuaniRios JuaniRios force-pushed the 09-25-new_e2e_tests branch from a9bd91b to 474234a Compare October 7, 2024 13:02
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 647e303 to ee5553b Compare October 7, 2024 13:02
@lrazovic lrazovic force-pushed the 09-25-new_e2e_tests branch from 474234a to b52b088 Compare October 8, 2024 13:27
@lrazovic lrazovic force-pushed the 10-04-usdt-fee-pjs-compatibility branch 2 times, most recently from 8b80f9b to 17de30f Compare October 8, 2024 13:29
@lrazovic lrazovic requested review from lrazovic and vstam1 October 8, 2024 13:29
@lrazovic lrazovic changed the title usdt-fee-pjs-compatibility 💥 Switch to MultiLocation in the SignedExtension Oct 8, 2024
@lrazovic lrazovic marked this pull request as ready for review October 8, 2024 13:34
lrazovic
lrazovic previously approved these changes Oct 8, 2024
Copy link

graphite-app bot commented Oct 8, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (10/08/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@lrazovic lrazovic dismissed their stale review October 9, 2024 08:50

After a cargo clean (even if I tested it using srtool), it doesn't compile. On it.

@JuaniRios JuaniRios force-pushed the 09-25-new_e2e_tests branch from b52b088 to 029390d Compare October 9, 2024 09:59
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 17de30f to 339eefb Compare October 9, 2024 10:00
@JuaniRios JuaniRios force-pushed the 09-25-new_e2e_tests branch from 029390d to db429d4 Compare October 10, 2024 09:37
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch 2 times, most recently from 5e8b4f5 to 3701e31 Compare October 10, 2024 09:39
@JuaniRios JuaniRios force-pushed the 09-25-new_e2e_tests branch from db429d4 to 85e29bc Compare October 10, 2024 09:43
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 3701e31 to 53d5063 Compare October 10, 2024 09:43
@JuaniRios JuaniRios force-pushed the 09-25-new_e2e_tests branch from 85e29bc to 3a86fb8 Compare October 10, 2024 09:53
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 53d5063 to b7d6648 Compare October 10, 2024 09:53
@lrazovic lrazovic force-pushed the 09-25-new_e2e_tests branch from 3a86fb8 to 9ddd19c Compare October 10, 2024 11:58
@lrazovic lrazovic force-pushed the 10-04-usdt-fee-pjs-compatibility branch from b7d6648 to 6ac47a9 Compare October 10, 2024 11:58
@JuaniRios JuaniRios force-pushed the 09-25-new_e2e_tests branch from 9ddd19c to 3a86fb8 Compare October 10, 2024 12:00
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 6ac47a9 to b7d6648 Compare October 10, 2024 12:00
@lrazovic lrazovic force-pushed the 09-25-new_e2e_tests branch from 3a86fb8 to 9ddd19c Compare October 10, 2024 12:20
@lrazovic lrazovic force-pushed the 10-04-usdt-fee-pjs-compatibility branch from b7d6648 to 6ac47a9 Compare October 10, 2024 12:20
@JuaniRios JuaniRios force-pushed the 09-25-new_e2e_tests branch from 9ddd19c to 3a86fb8 Compare October 10, 2024 12:22
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 6ac47a9 to b7d6648 Compare October 10, 2024 12:23
@JuaniRios JuaniRios force-pushed the 09-25-new_e2e_tests branch from 3a86fb8 to 51d58f4 Compare October 10, 2024 13:47
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from b7d6648 to ae385b1 Compare October 10, 2024 13:47
Copy link
Contributor Author

JuaniRios commented Oct 10, 2024

Merge activity

  • Oct 10, 10:08 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 10, 10:25 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 10, 10:26 AM EDT: A user merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 09-25-new_e2e_tests to graphite-base/406 October 10, 2024 14:22
@JuaniRios JuaniRios changed the base branch from graphite-base/406 to main October 10, 2024 14:23
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from ae385b1 to 71020d8 Compare October 10, 2024 14:24
@JuaniRios JuaniRios merged commit 85088f5 into main Oct 10, 2024
1 check passed
@JuaniRios JuaniRios deleted the 10-04-usdt-fee-pjs-compatibility branch October 10, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants