dont try to render removed tile entities (#43)

README.md

@@ -236,6 +236,7 @@ This work, "PolyPatcher", is adapted from ["Patcher"](https://sk1er.club/mods/pa
 - Fix vanilla bug where enchantment glint takes up the whole slot
 - Fix vanilla bug where items glitch out when using negative scale
 - Fix vanilla bug where pumpkin overlay shows in spectator mode
+- Fix vanilla bug where invalid tile entities try to render
 - Fix vanilla sky lighting calculation
 - Fix texture manager memory leak
 - Fix compatability with LoliASM/CensoredASM

src/main/java/club/sk1er/patcher/mixins/performance/TileEntityRendererDispatcherMixin_BatchDraw.java

@@ -12,7 +12,6 @@
 
 @Mixin(value = TileEntityRendererDispatcher.class)
 public class TileEntityRendererDispatcherMixin_BatchDraw {
-
     //#if MC==10809
     @Unique private boolean patcher$drawingBatch = false;
 
@@ -36,5 +35,4 @@ public class TileEntityRendererDispatcherMixin_BatchDraw {
         return (!PatcherConfig.batchModelRendering || patcher$drawingBatch) && instance.hasFastRenderer();
     }
     //#endif
-
 }

src/main/java/club/sk1er/patcher/mixins/performance/TileEntityRendererDispatcherMixin_RemoveInvalidEntities.java

@@ -0,0 +1,21 @@
+package club.sk1er.patcher.mixins.performance;
+
+import net.minecraft.client.renderer.tileentity.TileEntityRendererDispatcher;
+import net.minecraft.client.renderer.tileentity.TileEntitySpecialRenderer;
+import net.minecraft.tileentity.TileEntity;
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.injection.At;
+import org.spongepowered.asm.mixin.injection.Inject;
+import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
+
+@Mixin(TileEntityRendererDispatcher.class)
+public class TileEntityRendererDispatcherMixin_RemoveInvalidEntities {
+    //#if MC==10809
+    @Inject(method = "getSpecialRenderer", at = @At("HEAD"), cancellable = true)
+    private <T extends TileEntity> void patcher$returnNullIfInvalid(TileEntity tileEntityIn, CallbackInfoReturnable<TileEntitySpecialRenderer<T>> cir) {
+        if (tileEntityIn == null || tileEntityIn.isInvalid()) {
+            cir.setReturnValue(null);
+        }
+    }
+    //#endif
+}

src/main/resources/mixins.patcher.json

@@ -249,6 +249,7 @@
     "performance.TextureManagerMixin_MemoryLeak",
     "performance.TileEntityMobSpawnerRendererMixin_EntityCulling",
     "performance.TileEntityRendererDispatcherMixin_BatchDraw",
+    "performance.TileEntityRendererDispatcherMixin_RemoveInvalidEntities",
     "performance.VisGraphMixin_LimitScan",
     "performance.WorldClientMixin_AnimationTick",
     "performance.WorldMixin_Optimization",