Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ver/6.4.2 #441

Merged
merged 40 commits into from
Dec 18, 2023
Merged

Ver/6.4.2 #441

merged 40 commits into from
Dec 18, 2023

Conversation

duplexsystem
Copy link
Member

@duplexsystem duplexsystem commented Dec 9, 2023

Terra Version 6.4.2

  • 1.20.3/4
  • bring minimum supported minecraft version to 1.20.[3/4]
  • enforce NMS bindings
  • fix CME
  • additional warning if not using paper(+) as we super depend on it now
  • minor git ignore changes
  • small perf opt

Copy link
Member

@astrsh astrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly platform stuff so I don't have too much to add

String newid = "minecraft:" + id.toLowerCase();;
logger.warn(
"Translating " + id + " to " + newid + ". In 1.20.3 entity parsing was reworked" +
". You are advised to preform this rename in your config backs as this translation will be removed in the next major " +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preform typo

Copy link

@justaureus justaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just had the one question about the minimum version. :)

@duplexsystem duplexsystem merged commit da4ab8b into master Dec 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants