Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Delay firing iron-iconset-added until iconset fully parsed. #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrey-git
Copy link

On Chrome a custom element constructor and lifecycle callbacks are called as soon as the tag itself is parsed, i.e. <iron-iconset-svg ... > but possibly before the child elements are parsed.

This PR handles this case by waiting for DOMContentLoaded before firing iron-iconset-added if the document is in loading state

@andrey-git
Copy link
Author

Fixes #66

@balloob
Copy link

balloob commented Apr 23, 2018

This PR actually fixes a problem I have with loading icon sets on demand. I really hope that we can get this fixed or addressed somehow once Polymer 3 has shipped and the elements will get some love.

On a side note, waiting for DOMContentLoaded before firing the event can be bad for performance. Imagine an iconset at the top of a page that is huge. Neat trick that I learned from AMP: it skips waiting for DOMContentLoaded if they know parsing is already done. They check this by seeing if element or any parent element has a sibling. If so, the children must have been done parsing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants