make sure event.target is the real addons target #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately we are still doing a large internal migration that may result in an external major release of paper-input. We are in a code freeze for the element and iron-input in the meanwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the real addons target to be added as addons.
Due to shadowDom event retargeting,
event.targetis is not the addon anymore in some advanced templating scenario. As a result,updateAddonscall a not-existingupdatemethod, creating an error.This PR makes sure we add the initial event target.
This PR is against the 2.x branch (which I use), but the observed error is expected to happen under 3.x as well.