Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🤖 update to latest polkadot dependencies #1035

Merged
merged 1 commit into from
Sep 4, 2023
Merged

chore: 🤖 update to latest polkadot dependencies #1035

merged 1 commit into from
Sep 4, 2023

Conversation

polymath-eric
Copy link
Collaborator

@polymath-eric polymath-eric commented Sep 1, 2023 •
edited by jira bot
Loading

Description

use @polkadot/dev-ts as node loader for typegen to avoid errors

Breaking Changes

None

JIRA Link

DA-850

Checklist

  • Updated the Readme.md (if required) ?

@polymath-eric
chore: 🤖 update to latest polkadot dependencies
e15f4f3 
use @polkadot/dev-ts as node loader for typegen to avoid errors
@polymath-eric polymath-eric requested a review from a team as a code owner September 1, 2023 18:44
@polymath-eric
Copy link
Collaborator Author

polymath-eric commented Sep 1, 2023 •
edited
Loading

Current versions of typegen want to run in a "type": "module" environment, however this would be a pretty big breaking change for us, and potentially our consumers.

Using the polkadot node loader allows the newer versions to be backwards compatible, so lets us upgrade to the latest versions.

The solution was found on this comment: polkadot-js/docs#419

This is the distant 3rd best, but adding in "type": "module" isn't a trivial change for us, and consumers.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@VictorVicente VictorVicente merged commit 233a457 into beta Sep 4, 2023
@VictorVicente VictorVicente deleted the update-polkadot branch September 4, 2023 13:24
@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 22.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 22.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVicente VictorVicente VictorVicente approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polymath-eric @prashantasdeveloper @VictorVicente