MultiStrategyVault #145
MultiStrategyVault #145
Conversation
src/vaults/MultiStrategyVault.sol
Outdated
| function _withdrawStrategyFunds(uint256 amount) internal { | ||
| // Get the Vault's floating balance. | ||
| uint256 float = IERC20(asset()).balanceOf(address(this)); | ||
|
|
||
| // If the amount is greater than the float, withdraw from strategies. | ||
| if (amount > float) { | ||
| // We'll start at the tip of the stack and traverse backwards. | ||
| uint256 currentIndex = strategies.length - 1; | ||
|
|
||
| // Iterate in reverse so we pull from the stack in a "last in, first out" manner. | ||
| // Will revert due to underflow if we empty the stack before pulling the desired amount. | ||
| for (; ; currentIndex--) { | ||
| uint256 missing = amount - float; | ||
|
|
||
| IERC4626 strategy = strategies[currentIndex]; | ||
|
|
||
| uint256 withdrawableAssets = strategy.previewRedeem( | ||
| strategy.balanceOf(address(this)) | ||
| ); | ||
|
|
||
| if (withdrawableAssets >= missing) { | ||
| strategy.withdraw(missing, address(this), address(this)); | ||
| break; | ||
| } else if (withdrawableAssets > 0) { | ||
| strategy.withdraw( | ||
| withdrawableAssets, | ||
| address(this), | ||
| address(this) | ||
| ); | ||
| float += withdrawableAssets; | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
we can save gas by sending the funds directly to the user:
if float > amount: send all funds from vault's own balance, if float < amount: withdraw from strat and send directly to user. Vault's funds stay in the vault.
That way we'd minimize the amount of ERC20 tranfers.
There was a problem hiding this comment.
i mean if we have enough float the function should return and we have the transfer in the withdrawal function. Or am i missing smth?
There was a problem hiding this comment.
yeah but if we don't have enough float we pull from the strats to the vault and then transfer from the vault to the user.
So ERC20 flows:
strat1 -> vault
strat2 -> vault
strat3 -> vault
vault -> user
if we do:
strat1 -> user
strat2 -> user
strat3 -> user
we have 1 less ERC20 transfer which is about ~50k gas I think
There was a problem hiding this comment.
That'll be the default flow for withdrawals anyways since the vault will only hold assets when paused or strats are changed.
There was a problem hiding this comment.
aaaah gotcha! makes sense. ill change that
No description provided.