Feat/price update over time #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/price update over time
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
| // Check for price jump or drawdown | ||
| if ( | ||
| // Check if the changePerBlock is too large | ||
| changePerBlock > lastPrice.mulDivDown(1e18 + limit.jump, 1e18) |
There was a problem hiding this comment.
I wonder if this check is effective given that the owner can change limits instantly
| changePerBlock > lastPrice.mulDivDown(1e18 + limit.jump, 1e18) | ||
| ) { | ||
| // Pause the vault if it is not already paused | ||
| if (!Pausable(priceUpdate.vault).paused()) { |
There was a problem hiding this comment.
Let's use the pause cached above. Also, should we check the vault is not paused at all before updating?
| uint256 y = 100e18; | ||
| uint256 z = 100e18; | ||
| console2.log(x.mulDivUp(y, z)); | ||
| emit LogBytes( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.