Vaults v2 #91
Closed
Vaults v2 #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedVeil
commented
Oct 13, 2023
RedVeil
commented
Oct 13, 2023
RedVeil
commented
Oct 13, 2023
RedVeil
commented
Oct 13, 2023
RedVeil
commented
Oct 13, 2023
|
I think we should write an example looping/leverage strategy to test if V2 can handle it. And one that kicks back rewards to a vault which distributes to the users. Other than that it looks pretty good! |
…folder Move v2 files into src folder
refactor(adapter/aave): use constants and remove unused stuff
refactor: adapter & strats
fix(CurveCompounder): only swap if balance > 0
test(strats/aavev3): add delta for deposit & withdrawal
RedVeil
commented
Nov 24, 2023
src/base/BaseVault.sol
Outdated
| _decimals = IERC20Metadata(address(asset_)).decimals() + decimalOffset; // Asset decimals + decimal offset to combat inflation attacks | ||
| _decimals = | ||
| IERC20Metadata(address(vaultConfig.asset_)).decimals() + | ||
| decimalOffset; // Asset decimals + decimal offset to combat inflation attacks |
There was a problem hiding this comment.
Using the new OZ 4626 implementation we can get rid of the offset no?
RedVeil
commented
Nov 24, 2023
src/base/BaseVault.sol
Outdated
|
|
||
| contractName = keccak256( | ||
| abi.encodePacked("Popcorn", name(), block.timestamp, "Vault") | ||
| abi.encodePacked("VaultCraft", name(), block.timestamp, " Vault") | ||
| ); | ||
|
|
||
| highWaterMark = 1e9; |
There was a problem hiding this comment.
This needs to be adjusted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.