Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

[WIP] Rework voice & music module #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

lightdiscord
Copy link
Contributor

@lightdiscord lightdiscord commented May 26, 2018

Trying to rework the voice and music module.

What to do?

  • Better queue system (Maybe a common one for both modules)
  • Better TTS system.
  • Stream interface

Optional

  • Pre-load next item in queue.
  • Let the client choose between every TTS engines.

Before merging

  • Code review
  • Uncomment modules

Unresolved questions

  • How to add a radio in the queue ? Should we put it at the end while there are music to play or should we next it to play other music ?

@lightdiscord lightdiscord self-assigned this May 26, 2018
@lightdiscord lightdiscord added enhancement work in progress When something is in progress labels May 26, 2018
@cchudant cchudant requested review from DeltaEvo and removed request for DeltaEvo May 26, 2018 12:24
@DeltaEvo
Copy link
Member

TTS should not enter the queue, but instead stop music, play tts and continue music

@DeltaEvo
Copy link
Member

We can get the current stream with https://discord.js.org/#/docs/main/stable/class/StreamDispatcher?scrollTo=stream
save it, play a new and after the end replay the old stream
But we need to delay the handling of the events https://github.com/Popcorn-moe/Discord/blob/master/src/modules/Music/index.js#L185 to the next stream

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement work in progress When something is in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants