Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwjs binary updated to latest to fix segment fault on macOS Sierra #107

Merged

Conversation

haroondilshad
Copy link

This PR will resolve #105 and #106 . I investigated the issue and it was most probably a segfault and the latest version of nwjs fixes that. I reached at that conclusion because exited with code 11 usually refers to a segment fault so I went ahead and tested with Node Segment fault handler and that indeed was the issue. It'll be very hard to actually try to track the issue down and fix while staying with this very outdated version of nwjs and in my opinion, future is the way to go.

@haroondilshad
Copy link
Author

@YIFYtorrents please merge

@haroondilshad
Copy link
Author

With newer versions of nw-builder this is reported
[Error: Unsupported NW.js version '0.12.3 (sdk)' for platform 'osx64']
There's not much support for 0.12.3 anymore and we should move on for the better

@YIFYtorrents
Copy link
Contributor

YIFYtorrents commented Dec 19, 2016

There's not much support for 0.12.3 anymore and we should move on for the better

That is a good idea, by the way I just saw this PR the first time. I am going to merge it as soon as I have tested it.

@captainyarr
Copy link
Contributor

My test haven't been positive with this PR running in Linux, but could be just me. Let me know if you have better results.

@haroondilshad
Copy link
Author

@captainyarr If you can test further and make a comprehensive list of issues I'd be willing to fix them in a few days' time. @YIFYtorrents I didn't test it comprehensively and just tested on Sierra, if your tests reveal something broken I'd be more than happy to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App exited with code 11 (macOS Sierra)
3 participants