-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Recorder role #31
A Recorder role #31
Conversation
76b8d62
to
ee3aea4
Compare
Let me know when you want me to re-review this |
@kpeters-cbsi Just cleared out the last of the signatures, so if you don't mind having an inspection. |
ok, i'll have a look-see this evening
…On Wed, Aug 4, 2021 at 5:20 AM Roy Storey ***@***.***> wrote:
@kpeters-cbsi <https://github.com/kpeters-cbsi> Just cleared out the last
of the signatures, so if you don't mind having an inspection.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGUGC7VYRMNB5JJEOCJ53T3EH7FANCNFSM4Z2672UQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
--
Kit Peters, W0KEH
GPG public key fingerpint: D4FF AA62 AFEA 83D6 CC98 ACE5 6FAE 7E74 7F56 ED1D
Hello to any and all NSA, DEA, or other government or non-government agents
reading this email. Tell me about your life; I'll tell you about mine.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
my $t = Test::Mojo->new; | ||
my (@results, @transactions); | ||
my @promises = ( | ||
$t->ua->get_p(q{https://www.vam.ac.uk/api/json/museumobject/O1}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but in future I think we should do away with the external websites altogether and instead fork a dedicated HTTP server to test against. Provided, of course, that doesn't break Jenkins...
In response to #30, this PR adds a recorder role, which is easier to compose in.
There's only 2 tests, one standalone UA and one with a lite app, but it is in a reasonable state to kick around.