Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the scan for Graphql Introspection Query Enabled #175

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

j3ssie
Copy link
Contributor

@j3ssie j3ssie commented Feb 6, 2024

BCheck Contributions

  • BCheck compiles and executes as expected
  • BCheck contains appropriate metadata (name, version, author, description and appropriate tags)
  • Only .bcheck files have been added or modified
  • BCheck is in the appropriate folder
  • PR contains single or limited number of BChecks (Multiple PRs are preferred)
  • BCheck attempts to minimize false positives

other/files/ds-store-exposed.bcheck Outdated Show resolved Hide resolved
other/files/ds-store-exposed.bcheck Show resolved Hide resolved
other/files/svn-exposed.bcheck Outdated Show resolved Hide resolved
other/files/svn-exposed.bcheck Outdated Show resolved Hide resolved
other/files/svn-exposed.bcheck Show resolved Hide resolved
@j3ssie
Copy link
Contributor Author

j3ssie commented Feb 8, 2024

I believe I've addressed all the issues you mentioned, @PortSwiggerWiener. Would you prefer a new PR (with this one close), or should I continue updating within this commit?

@Hannah-PortSwigger
Copy link
Contributor

I believe I've addressed all the issues you mentioned, @PortSwiggerWiener. Would you prefer a new PR (with this one close), or should I continue updating within this commit?

Thanks for making the changes! Whichever is easiest for you is fine - we don't mind.

Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for considering the comments.

Looks good 👍

other/files/svn-exposed.bcheck Show resolved Hide resolved
@Hannah-PortSwigger
Copy link
Contributor

@j3ssie We've made some small adjustments to your BChecks. Could you please check that these line up with your intended behavior?

@j3ssie
Copy link
Contributor Author

j3ssie commented Feb 9, 2024

Everything appears to be in order from my end, @Hannah-PortSwigger. Please feel free to review and approve the PR for merging at your convenience

@Hannah-PortSwigger Hannah-PortSwigger merged commit 604dfcc into PortSwigger:main Feb 9, 2024
1 check passed
@Hannah-PortSwigger
Copy link
Contributor

Thank you very much for your contributions to the BChecks repository 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants