Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making API Key optional is self hosted gateway #132

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

csgulati09
Copy link
Collaborator

@csgulati09 csgulati09 commented Oct 10, 2024

Title: Making API Key optional is self hosted gateway

Description:

  • Checking if it is not PORTKEY_BASE_URL then keep apiKey optional
  • If apiKey not present, then set baseURL as localhost

Related Issues:
Fixes #131

@csgulati09 csgulati09 self-assigned this Oct 10, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 10, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 11, 2024
@csgulati09 csgulati09 marked this pull request as draft November 5, 2024 09:35
@csgulati09 csgulati09 marked this pull request as ready for review November 21, 2024 10:27
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 21, 2024
@csgulati09 csgulati09 requested a review from VisargD November 21, 2024 10:27
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2024
@csgulati09 csgulati09 merged commit bf91ab4 into main Nov 21, 2024
1 check passed
@csgulati09 csgulati09 deleted the feat/apiKey-optional branch November 21, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeSDK: API Key Optional for self hosted
2 participants