Descent 1,2,3: Replace symbolic links with bind mounts. #1052
Conversation
t0b10-r3tr0
requested review from
cdeletre,
Cebion,
JanTrueno,
JeodC,
Slayer366,
tabreturn and
kloptops
as code owners
ports/alephone-marathon/Marathon.sh
Outdated
There was a problem hiding this comment.
Aren't these in PR 1050 ?
There was a problem hiding this comment.
No. Descent and Marathon. They're different developers, platforms, etc. Descent was on DOS, by Interplay(?) and Marathon was on Mac, by Bungie. They're both oddly packaged by 3. Hahaha. I am so dense sometimes. Fixing this.
There was a problem hiding this comment.
It's now fixed. I don't know how those two got mixed up but after merging with upstream, it resolved itself and both PRs are only associated the files related to the PR.
| @@ -57,7 +56,7 @@ else | |||
| fi | |||
|
|
|||
| if [ "$LIBGL_FB" != "" ]; then | |||
| export SDL_VIDEO_GL_DRIVER="$GAMEDIR/gl4es.aarch64/libGL.so.1" | |||
There was a problem hiding this comment.
What does this change have to do with bind mounts?
There was a problem hiding this comment.
This was one of the issues we had to address because it prevented the port from starting. So, it was done in the context of the bind-directories fixes. I figured not to make 2 PRs for the change.
There was a problem hiding this comment.
I know but the title of the PR is replace symbolic links and then does other things :P
To enable exFAT support on certain CFWs, We replaced symbolic links with bind mounts using the
bind_directoriesfunction included with PortMaster GUI.The scope of this task was limited to implementing bind_directories and any fixes preventing the port from launching. Each port was tested in Knulli and one other PM supported CFW (ROCKNIX, most times).
The following criteria were used to validate that a port had passed our testing: