-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate dynamic libraries #865
base: main
Are you sure you want to change the base?
Conversation
Tested with f-zero pocket and ufo 50, works. Will test more ports throughout the day. |
Note: libgl logic will need to be rewritten in the libgl_cfw if we move them out of gl4es folders. |
Best to mark this as draft until it's ready |
Correct, and all of those are gl4es I believe. They have been consolidated to one version in PortMaster/libs/aarch64. |
|
I'm all for consolidating the libs. This is indeed an excellent idea. However, this should not be done for GL4ES as with first-hand experience, it's the same reason we don't do it for box86 and box64. Each game may have its own slightly different compiled version of GL4ES for each game. I did this very thing for Quakespasm as the one that was tossed to me made 4 frames less on an already low-framerate that it made 6 fps where my compiled version for Quakespasm at the time got 10 fps. Placing one version of GL4ES for all titles just doesn't seem like the best idea. |
Right but I only moved md5sum matching. If we need to we can do sub folders for gl4es versions maybe. |
Depends on PortsMaster/PortMaster-GUI#178