Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate dynamic libraries #865

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

JeodC
Copy link
Collaborator

@JeodC JeodC commented Oct 27, 2024

  • Purges duplicate dynamic libraries with matching md5sums
  • Modifies all relevant sh files to point to new PortMaster libstore

Depends on PortsMaster/PortMaster-GUI#178

@JeodC
Copy link
Collaborator Author

JeodC commented Oct 27, 2024

Tested with f-zero pocket and ufo 50, works. Will test more ports throughout the day.

@Cebion
Copy link
Collaborator

Cebion commented Oct 27, 2024

Note: libgl logic will need to be rewritten in the libgl_cfw if we move them out of gl4es folders.

@Cebion
Copy link
Collaborator

Cebion commented Oct 27, 2024

Best to mark this as draft until it's ready

@JeodC
Copy link
Collaborator Author

JeodC commented Oct 27, 2024

Note: libgl logic will need to be rewritten in the libgl_cfw if we move them out of gl4es folders.

Correct, and all of those are gl4es I believe. They have been consolidated to one version in PortMaster/libs/aarch64.

@Cebion
Copy link
Collaborator

Cebion commented Oct 27, 2024

Note: libgl logic will need to be rewritten in the libgl_cfw if we move them out of gl4es folders.

Correct, and all of those are gl4es I believe. They have been consolidated to one version in PortMaster/libs/aarch64.
The reason we put them into a gl4es folder outside of libs is to only load them on CFW that need them. Rocknix on Panfrost for example has full opengl and if you load gl4es it'll break the port. So in the gui in libgl_rocknix there is a statement to load the the gl4es folder if no panfrost is found else load the lib. So can't live in the same folder.

@Slayer366
Copy link
Collaborator

Note: libgl logic will need to be rewritten in the libgl_cfw if we move them out of gl4es folders.

Correct, and all of those are gl4es I believe. They have been consolidated to one version in PortMaster/libs/aarch64.

I'm all for consolidating the libs. This is indeed an excellent idea. However, this should not be done for GL4ES as with first-hand experience, it's the same reason we don't do it for box86 and box64. Each game may have its own slightly different compiled version of GL4ES for each game. I did this very thing for Quakespasm as the one that was tossed to me made 4 frames less on an already low-framerate that it made 6 fps where my compiled version for Quakespasm at the time got 10 fps. Placing one version of GL4ES for all titles just doesn't seem like the best idea.

@JeodC
Copy link
Collaborator Author

JeodC commented Oct 28, 2024

Right but I only moved md5sum matching. If we need to we can do sub folders for gl4es versions maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants