-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hexen 2, condense libs, fix ogg playback on JelOS #94
Conversation
…o one directory, removed libs that interfered with ogg playback on JelOS
@Slayer366 I do have a question. Why are you deleting the files in the .sh instead of deleting them from the package? |
Looks like you answered your own question. |
I know, but! after they were removed once, the script will try to delete these files every time. |
I've certainly removed the files from the package, but like you pointed out if someone overwrites an existing installation by re-installing they will be present on that individual's memory stick still. If the files don't exist, the rm command will simply complain that those files are not present and the script will continue anyway. The end user probably won't ever see the error message anyway. I can remove the delete line, but I guess it'll have to be stated somewhere to at least delete the old libs folder prior to reinstalling if doing so from the previous release. My goal was simply to attempt a fail-safe update for everyone (if that makes sense). Setting it to do a check if the files exist prior to deletion would be fine, but I was also trying desperately to keep the shell script short, too. |
😃 |
I see that it only checks for the one file, but that's good enough for me. I'll make this change rq. |
…bs prior to deletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Update Hexen 2 scripts, detect devices with triggers, condense libs to one directory, removed libs that interfered with ogg playback on JelOS