Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Containers image is hardcoded #379

Closed
dvirp-dt opened this issue May 11, 2022 · 4 comments
Closed

Init Containers image is hardcoded #379

dvirp-dt opened this issue May 11, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@dvirp-dt
Copy link

Proposed change

Currently, busybox init container is hardcoded in "_snippet-initContainers-wait-for-service-dependencies.tpl" file.
I would suggest adding an option to set it via the values file.

Additional context

This feature is super important to me since I can't deploy the chart without it.
My environment does not have internet access and I would like to deploy it without changing the chart.

@dvirp-dt dvirp-dt added the enhancement New feature or request label May 11, 2022
@dvirp-dt
Copy link
Author

@hazzadous This issue is similar to #370.
Do you see any reason to keep it hardcoded?

@hazzadous
Copy link
Contributor

hazzadous commented May 11, 2022

@dvirp-dt no reason to keep this one hard coded. The clickhouse-operator one is slightly more involved.

Do you happen to have a list of all the images you'd need to customise that you currently can't?

Also, I haven't tried but perhaps there is a way to specify a registry mirror that you control as a way to handle this? i.e. you'd change the default registry address rather than needing to change the referenced images in the chart. (I have no idea if this is actually possible btw)

hazzadous pushed a commit that referenced this issue May 11, 2022
In cases where you do not have access to dockerhub, it becomes necessary
to be able to specify an image from a different repo.

Refers #379
@dvirp-dt
Copy link
Author

@hazzadous Nice idea, I'll try.
Thanks for your quick response.

hazzadous pushed a commit that referenced this issue May 16, 2022
In cases where you do not have access to dockerhub, it becomes necessary
to be able to specify an image from a different repo.

Refers #379
@guidoiaquinti
Copy link
Contributor

Hey 👋 @dvirp-dt, did you make any progress on this? In the meantime we've released a change to allow specify a custom image for the init container via values.yaml.

I'm closing this issue as solved but please let us know if we've missed anything. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants