feat(busybox): allow specifying a custom image #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where you do not have access to dockerhub, it becomes necessary to be able to specify an image from a different repo. Refers #379
|
Closing as setting default repo as mentioned in the referenced ticket is probably a better approach |
Hey @hazzadous, after quick research I've understood there is no quick way to configure the registry in cluster-lever. |
|
@dvirp-dt ah that's a shame, I'll open and add some reviewers. |
hazzadous
requested review from
guidoiaquinti,
fuziontech and
benjackwhite
and removed request for
fuziontech
Thanks. |
guidoiaquinti
approved these changes
May 16, 2022
|
We probably forgot to bump the chart with this merge. No worries head over to https://github.com/PostHog/charts-clickhouse/actions/workflows/bump-version-workflow-dispatch.yaml to trigger the chart update. |
fuziontech
added a commit
that referenced
this pull request
May 17, 2022
* main: Bump version to 20.0.1 Regenerate chart ALL_VALUES.md feat(busybox): allow specifying a custom image (#380)
fuziontech
added a commit
that referenced
this pull request
May 17, 2022
* main: Bump version to 20.0.1 Regenerate chart ALL_VALUES.md feat(busybox): allow specifying a custom image (#380)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where you do not have access to dockerhub, it becomes necessary
to be able to specify an image from a different repo.
Refers #379
Description
Type of change
How has this been tested?
Checklist