Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(busybox): allow specifying a custom image #380

Merged
merged 1 commit into from
May 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{{/* Common initContainers-wait-for-service-dependencies definition */}}
{{- define "_snippet-initContainers-wait-for-service-dependencies" }}
- name: wait-for-service-dependencies
image: busybox:1.34
image: {{ .Values.busybox.image }}
env:
{{- include "snippet.clickhouse-env" . | nindent 4 }}
command:
Expand Down
21 changes: 21 additions & 0 deletions charts/posthog/tests/web-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,24 @@ tests:
count: 1
- isKind:
of: Deployment

- it: should allow specifying a custom busybox image for init containers
template: templates/web-deployment.yaml
set:
cloud: local
busybox:
image: some-customer-image
asserts:
- equal:
path: spec.template.spec.initContainers[0].image
value: some-customer-image

- it: should have a default image for init containers
template: templates/web-deployment.yaml
set:
cloud: local
asserts:
- equal:
path: spec.template.spec.initContainers[0].image
value: busybox:1.34

4 changes: 4 additions & 0 deletions charts/posthog/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -983,3 +983,7 @@ prometheus-redis-exporter:
###
###
installCustomStorageClass: false

busybox:
# -- Specify the image to use for e.g. init containers
image: busybox:1.34