Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify nodeSelector and env variables #312

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

guidoiaquinti
Copy link
Contributor

Description

  • make sure deployments & migrate job have the option to configure affinity, tolerations and nodeSelector
  • rename .Values.hooks.migrate to .Values.migration

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@klamas1
Copy link
Contributor

klamas1 commented Aug 30, 2022

This pull request breaks the backward compatibility of values.
Can we start by simply adding tolerations and nodeSelector to migrations?

@guidoiaquinti
Copy link
Contributor Author

This pull request breaks the backward compatibility of values. Can we start by simply adding tolerations and nodeSelector to migrations?

This is an old PR that we still might want to merge that is supposed to be a breaking change for the chart.

@klamas1
Copy link
Contributor

klamas1 commented Aug 30, 2022

Then maybe make a separate PR with only tolerations and nodeSelector to migrations ?
I need these options now, but doing it only in my fork is not convenient

@guidoiaquinti
Copy link
Contributor Author

Then maybe make a separate PR with only tolerations and nodeSelector to migrations ? I need these options now, but doing it only in my fork is not convenient

Feel free to open another PR and we'll be happy to review it

@klamas1
Copy link
Contributor

klamas1 commented Aug 30, 2022

Thanks, i did it #564

@klamas1
Copy link
Contributor

klamas1 commented Nov 10, 2022

I created a new PR, in which I added the ability to globally specify affinity, tolerations and nodeSelector for all deployments, of which there are already quite a lot.

#620
Please check it out, maybe it will replace the current PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants