-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(session-recordings): separate session recordings from events #666
base: main
Are you sure you want to change the base?
Conversation
We currently have session recordings events going to the same endpoint as analytics events and decide endpiont. The characteristics of session recordings is quite different, and our expectations of priority. It's much more important that we capture events and service decide endpoints than we capture all session recordings. This separates the deployment to offer more flexibility in providing different service availability.
c5fa638
to
b5ebf64
Compare
d0d5feb
to
6dca122
Compare
resources: {} | ||
|
||
# -- Additional env variables to inject into the session recordings stack, uses `web.env` if empty. | ||
env: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env: [] | |
env: [ | |
DEPLOYMENT_ROLE: "SESSION_RECORDINGS_CAPTURE" | |
] |
I came poking about in this repo to figure out how to make exactly this and this PR is sat here like it's already xmas 🎉 I'm guessing it's safe to deploy this because we won't route traffic to it automatically? I'd be interested in getting it reading production traffic but not pushing on to actually ingest so we can run some experiments on how we're chunking and compressing recordings... |
I can't remember what the rollout strategy is but yeah I think something like get the deployment up first with no traffic routed (so we can be sure the ingress isn't pointing to a non-existent deployment on initial deploy), then do another to have things routed. Please accept this present 🎁 and feel free to get it deployed. |
We currently have session recordings events going to the same endpoint
as analytics events and decide endpiont. The characteristics of session
recordings is quite different, and our expectations of priority. It's
much more important that we capture events and service decide endpoints
than we capture all session recordings.
This separates the deployment to offer more flexibility in providing
different service availability.
Description
Type of change
How has this been tested?
Checklist