Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(session-recordings): separate session recordings from events #666

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hazzadous
Copy link
Contributor

We currently have session recordings events going to the same endpoint
as analytics events and decide endpiont. The characteristics of session
recordings is quite different, and our expectations of priority. It's
much more important that we capture events and service decide endpoints
than we capture all session recordings.

This separates the deployment to offer more flexibility in providing
different service availability.

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

We currently have session recordings events going to the same endpoint
as analytics events and decide endpiont. The characteristics of session
recordings is quite different, and our expectations of priority. It's
much more important that we capture events and service decide endpoints
than we capture all session recordings.

This separates the deployment to offer more flexibility in providing
different service availability.
@hazzadous hazzadous force-pushed the chore/separate-session-recordings branch from c5fa638 to b5ebf64 Compare January 11, 2023 18:49
@hazzadous hazzadous force-pushed the chore/separate-session-recordings branch from d0d5feb to 6dca122 Compare January 11, 2023 18:51
@hazzadous hazzadous requested a review from tomasfarias January 11, 2023 22:15
@hazzadous hazzadous mentioned this pull request Feb 10, 2023
6 tasks
resources: {}

# -- Additional env variables to inject into the session recordings stack, uses `web.env` if empty.
env: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
env: []
env: [
DEPLOYMENT_ROLE: "SESSION_RECORDINGS_CAPTURE"
]

@pauldambra
Copy link
Member

I came poking about in this repo to figure out how to make exactly this and this PR is sat here like it's already xmas 🎉

I'm guessing it's safe to deploy this because we won't route traffic to it automatically?

I'd be interested in getting it reading production traffic but not pushing on to actually ingest so we can run some experiments on how we're chunking and compressing recordings...

@hazzadous
Copy link
Contributor Author

I came poking about in this repo to figure out how to make exactly this and this PR is sat here like it's already xmas 🎉

I'm guessing it's safe to deploy this because we won't route traffic to it automatically?

I'd be interested in getting it reading production traffic but not pushing on to actually ingest so we can run some experiments on how we're chunking and compressing recordings...

I can't remember what the rollout strategy is but yeah I think something like get the deployment up first with no traffic routed (so we can be sure the ingress isn't pointing to a non-existent deployment on initial deploy), then do another to have things routed.

Please accept this present 🎁 and feel free to get it deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants