recording: OnTouchEventListener try catch guard to swallow unexpected errors take 2 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Oct 7, 2024
| } | ||
| } catch (e: Throwable) { | ||
| config.logger.log("Executor#OnTouchEventListener $motionEvent failed: $e.") |
There was a problem hiding this comment.
if this happens, its our fault
marandaneto
commented
Oct 7, 2024
Comment on lines
+244
to
+245
| config.logger.log("TouchEventInterceptor $motionEvent failed: $e.") | ||
| throw e |
There was a problem hiding this comment.
if this happens, its not our fault
marandaneto
commented
Oct 7, 2024
| @@ -216,27 +216,34 @@ public class PostHogReplayIntegration( | |||
| } | |||
|
|
|||
| private val onTouchEventListener = | |||
| OnTouchEventListener { motionEvent -> | |||
| TouchEventInterceptor { motionEvent, dispatch -> | |||
There was a problem hiding this comment.
changed to a lower level interceptor, so we call the dispatch and log out
ioannisj
approved these changes
Oct 9, 2024
this code is not even executed if session replay is disabled, so moving the check would not have any effect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Tries to fix https://github.com/PostHog/posthog-react-native-session-replay/issues/4
It's unclear if PostHog SDK is responsible for that, since the SDK intercepts the touch, the SDK will be always part of the stack trace, it does not mean its the SDK causing it.
💚 How did you test it?
📝 Checklist