Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add replay masking to jetpack compose views #198

Merged
merged 9 commits into from
Oct 30, 2024
Merged

feat: add replay masking to jetpack compose views #198

merged 9 commits into from
Oct 30, 2024

Conversation

beradeep
Copy link
Contributor

💡 Motivation and Context

Fix #158

💚 How did you test it?

Tested on a sample app. Auto as well as manual masking using Modifier.postHogMaskReplay(), both working as expected.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@beradeep beradeep requested a review from marandaneto as a code owner October 16, 2024 10:42
@beradeep beradeep changed the title add replay masking to jetpack compose views feat: add replay masking to jetpack compose views Oct 16, 2024
@marandaneto
Copy link
Member

Nice @beradeep thanks for the PR
Left a few comments but that pretty much aligns with the solution I had in mind and is very similar to how it's done in SwiftUI as well.

@beradeep
Copy link
Contributor Author

@marandaneto Thanks for the review! I'll try to incorporate all of the above.

@marandaneto
Copy link
Member

@beradeep sorry the delay I was on PTO, did another pass, almost there.

@marandaneto
Copy link
Member

@beradeep add a new entry to https://github.com/PostHog/posthog-android/blob/main/CHANGELOG.md#next please :)

@beradeep
Copy link
Contributor Author

@beradeep add a new entry to https://github.com/PostHog/posthog-android/blob/main/CHANGELOG.md#next please :)

ah yes, for sure 😄

@marandaneto marandaneto merged commit 594f538 into PostHog:main Oct 30, 2024
4 checks passed
@marandaneto marandaneto mentioned this pull request Oct 30, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Masking and redacting Jetpack Compose views
2 participants
@beradeep @marandaneto