fix: recording for flutter does not capture screenshots on both sides #208
+62
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisj
approved these changes
Nov 26, 2024
| @@ -121,6 +121,10 @@ public class PostHogReplayIntegration( | |||
| private val isSessionReplayEnabled: Boolean | |||
| get() = PostHog.isSessionReplayActive() | |||
|
|
|||
| // flutter captures snapshots, so we don't need to capture them here | |||
| private val isNativeSdk: Boolean | |||
| get() = (config.sdkName != "posthog-flutter") | |||
There was a problem hiding this comment.
I imagine this is a computed property by design?
There was a problem hiding this comment.
There was a problem hiding this comment.
can be refactored but a string match should not be an issue for now
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
flutter already captures screenshots, we dont want to do it twice, we still need the replay integration
#skip-changelog
💚 How did you test it?
📝 Checklist