fix: handle zero touch coordinates #256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Closes #254
The likely cause of zeroed-out coordinates is that we were accessing UITouch asynchronously. I was able to replicate locally by adding a conditional breakpoint checking for zero location. Every touch event that hit the breakpoint had its associated
touch.view
,touch.window
andtouch.gestureRecognizers
erased.I think the system may be releasing or erasing this info by the time we handle it, so I changed to collect the necessary info on main thread, and then process async. I kept a failsafe check before capturing in place just in case.
💚 How did you test it?
Locally with sample projects
📝 Checklist