Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): skip snapshot during view controller transitions #265

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

ioannisj
Copy link
Contributor

💡 Motivation and Context

There are cases where masked views peek through during view controller transitions. This is because of two things:

  • the way we mask snapshot views. We look for visible views in the view hierarchy that are sensitive and then draw a masking rectangle on top of them
  • the way view transitions work on iOS: During a transition, the original view is hidden, and a snapshot() view is added in a transition context and animated between start and end position (or animated interactively).

A fix for this is to avoid capturing a snapshot between these transitions. This leads to slightly less appealing recordings, but with less chances of unintentionally revealing PII

before after
Before After

💚 How did you test it?

Local sample

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@ioannisj ioannisj requested a review from a team November 27, 2024 06:42
Copy link
Member

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@ioannisj ioannisj merged commit d90f0c7 into main Nov 28, 2024
6 checks passed
@ioannisj ioannisj deleted the fix/skip-snapshot-on-presentation-animations branch November 28, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants