feat(replay): skip snapshot during view controller transitions #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
There are cases where masked views peek through during view controller transitions. This is because of two things:
snapshot()
view is added in a transition context and animated between start and end position (or animated interactively).A fix for this is to avoid capturing a snapshot between these transitions. This leads to slightly less appealing recordings, but with less chances of unintentionally revealing PII
💚 How did you test it?
Local sample
📝 Checklist