fix

PostHog · Mar 25, 2024 · c5939b7 · c5939b7
1 parent 546d6fe
commit c5939b7
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/posthog-react-native/CHANGELOG.md b/posthog-react-native/CHANGELOG.md
@@ -1,3 +1,7 @@
+# Next
+
+1. If `captureNativeAppLifecycleEvents` is enabled, the event `Application Opened` with the property `from_background: true` is moved to its own event called `Application Became Active`. This event is triggered when the app is opened from the background. The `Application Opened` event is now only triggered when the app is opened from a cold start, aligning with the other integrations such as the `PostHogProvider` with the `captureLifecycleEvents` option and `initReactNativeNavigation` with the `captureLifecycleEvents` option.
+
 # 3.0.0 - 2024-03-18
 
 ## Added

diff --git a/posthog-react-native/src/frameworks/wix-navigation.ts b/posthog-react-native/src/frameworks/wix-navigation.ts
@@ -27,6 +27,7 @@ export const withReactNativeNavigation = (posthog: PostHog, options: PostHogAuto
     const appBuild = appProperties.$app_build
     const appVersion = appProperties.$app_version
 
+    // TODO: add missing initialUrl
     posthog.capture('Application Opened', {
       version: appVersion,
       build: appBuild,

diff --git a/posthog-react-native/src/hooks/useLifecycleTracker.ts b/posthog-react-native/src/hooks/useLifecycleTracker.ts
@@ -15,6 +15,7 @@ export function useLifecycleTracker(client?: PostHog): void {
 
     if (!openTrackedRef.current) {
       openTrackedRef.current = true
+      // TODO: add missing initialUrl
       posthog.capture('Application Opened', {
         version: appVersion,
         build: appBuild,

diff --git a/posthog-react-native/src/posthog-rn.ts b/posthog-react-native/src/posthog-rn.ts
@@ -31,7 +31,7 @@ export type PostHogOptions = PostHogCoreOptions & {
   customStorage?: PostHogCustomStorage
 
   // customAsyncStorage?: PostHogCustomAsyncStorage
-  /** Captures native app lifecycle events such as Application Installed, Application Updated, Application Opened and Application Backgrounded.
+  /** Captures native app lifecycle events such as Application Installed, Application Updated, Application Opened, Application Became Active and Application Backgrounded.
    * By default is false.
    * If you're already using the 'captureLifecycleEvents' options with 'withReactNativeNavigation' or 'PostHogProvider, you should not set this to true, otherwise you may see duplicated events.
    */
@@ -146,7 +146,7 @@ export class PostHog extends PostHogCore {
   getCommonEventProperties(): any {
     return {
       ...super.getCommonEventProperties(),
-      ...getAppProperties(),
+      ...this._appProperties,
       $screen_height: Dimensions.get('screen').height,
       $screen_width: Dimensions.get('screen').width,
     }

diff --git a/posthog-react-native/test/posthog.spec.ts b/posthog-react-native/test/posthog.spec.ts
@@ -304,7 +304,7 @@ describe('PostHog React Native', () => {
           },
         })
         expect(onCapture.mock.calls[3][0]).toMatchObject({
-          event: 'Application Opened',
+          event: 'Application Became Active',
           properties: {
             $app_build: '1',
             $app_version: '1.0.0',