-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sentry integration #141
Conversation
Easy, I’m following this one now |
…js-lite into feat/sentry-integration
After this PR it'd be cool to have docs -> https://posthog.com/docs/libraries/node similar to https://posthog.com/docs/libraries/python#sentry so it's more discoverable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yep was just doing this :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Clone of #120
Changes
Resolves #106 by porting the Sentry integration from
posthog-js
toposthog-js-lite
. I have decided to port this for Node only for now, since I don’t think (??)posthog-js
is in production yet. If we were to rely on a common core here some of the code would have to change.I am also unsure of how this library wants to differ from
posthog-js
—the main edits I made were stylistic, and I tried to type everything a bit more strongly, which was the… vibe I’m getting from this repo? So I’m submitting this PR early and we can figure out what you actually want here (I also didn’t write tests). I will leave comments with questions.Testing Strategy
I tested this manually by compiling the library & patching it into my own app. I tested that:
sentry.io
)eu.posthog.com
)I am happy to write a test (how?) or test more extensively, wanted to wait until we had a more-reviewed PR before we do that.
(@benjackwhite - added tests)
Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes
posthog.SentryIntegration
toposthog-node
. Usage: