-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): Add local props and flags to all calls #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing a test for adding default properties to all flag functions |
neilkakkar
commented
Jan 4, 2024
oh much nicer, thanks!! 😓 |
jurajmajerik
approved these changes
Jan 8, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Copy of PostHog/posthog-python#106
This turned out to be a lot trickier than expected, because I noticed a few issues. With the
sendFeatureFlags
capture option, it seems like we were dropping events, since on shutdown the feature flag promises aren't tracked for populating flag information, which means the capture is not enqueued.I can't yet think of a better way to solve this right now, so we just start tracking flag promises from within capture as well, annnd flush again on shutdown after pending promises have resolved, to make sure all new capture events queued are sent as well.
I'm also moving a few more things that should've been based on the onError emitter, and fixed tests that incorrectly assumed this was working fine.
(cc: @marandaneto @benjackwhite have a look here too please?)
Changes
Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes