Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: local props refactor #150

Merged
merged 10 commits into from
Jan 9, 2024
Merged

fix: local props refactor #150

merged 10 commits into from
Jan 9, 2024

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Jan 5, 2024 •
edited
Loading

Problem

Made some changes but pulled them to a PR as I'm not so sure about them

@neilkakkar:

  • Changes some of the expectations so that the payload for feature flag properties is always the same, regardless of source - worth checking if this is correct
  • Fixes a bad issue with the waitForPromises that probably caused a lot of confusion elsewhere so hopefully thats an improvement
  • This makes every capture call a promise but simplifies the logic and makes it more reliable which feels better

@benjackwhite benjackwhite marked this pull request as ready for review January 5, 2024 09:18
@benjackwhite benjackwhite removed the request for review from marandaneto January 5, 2024 09:18
@neilkakkar
Copy link
Contributor

works great, just tested it, thanks!

@neilkakkar neilkakkar merged commit e791895 into local-props Jan 9, 2024
3 checks passed
@neilkakkar neilkakkar deleted the fix/local-props branch January 9, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilkakkar neilkakkar Awaiting requested review from neilkakkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjackwhite @neilkakkar