Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move to uuidv7 #160

Merged
merged 22 commits into from
Feb 6, 2024
Merged

feat: Move to uuidv7 #160

merged 22 commits into from
Feb 6, 2024

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Jan 23, 2024

Problem

We moved to uuidv7 on posthog-js - maybe we should do the same for js-lite?

Changes

  • Moves the utils around and swaps to uuidv7 with the same approach as posthog-js

Release info Sub-libraries affected

Bump level

  • Major
  • Minor
  • Patch

Libraries affected

  • Swaps the internal uuid implementation to uuidv7
  • All of them
  • posthog-web
  • posthog-node
  • posthog-react-native

Changelog notes

  • Added support for X

Copy link
Member

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changelog/version missing, otherwise LGTM

Base automatically changed from feat/override-event-id to main January 23, 2024 15:00
Copy link

github-actions bot commented Jan 26, 2024

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were pretty careful when moving posthog-js across, so assuming you've done a sanity check of the uuids being generated here then I think 🚢 like a 🚀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🙌

@marandaneto
Copy link
Member

@benjackwhite should we merge this? (changelogs need fixing)

@benjackwhite
Copy link
Collaborator Author

@benjackwhite should we merge this? (changelogs need fixing)

Too many other things going on. Feel free to take over and merge if you are happy with it

@marandaneto marandaneto merged commit 7c5342b into main Feb 6, 2024
4 checks passed
@marandaneto marandaneto deleted the feat/uuidv7 branch February 6, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants