-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move to uuidv7 #160
feat: Move to uuidv7 #160
Conversation
# Conflicts: # posthog-react-native/CHANGELOG.md # posthog-react-native/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just changelog/version missing, otherwise LGTM
# Conflicts: # posthog-react-native/CHANGELOG.md
Size Change: 0 B 🆕 Total Size: 0 B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we were pretty careful when moving posthog-js across, so assuming you've done a sanity check of the uuids being generated here then I think 🚢 like a 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 🙌
@benjackwhite should we merge this? (changelogs need fixing) |
Too many other things going on. Feel free to take over and merge if you are happy with it |
Problem
We moved to uuidv7 on posthog-js - maybe we should do the same for js-lite?
Changes
Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes