device_name was set to devices user name for all events wrongly #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://github.com/react-native-device-info/react-native-device-info/blob/e46a5d4dba4e7d1f5e1da8b17c82829600f84d77/ios/RNDeviceInfo/RNDeviceInfo.m#L310-L333 is the correct method.
Instead of https://github.com/react-native-device-info/react-native-device-info/blob/e46a5d4dba4e7d1f5e1da8b17c82829600f84d77/ios/RNDeviceInfo/RNDeviceInfo.m#L150-L157 which returns https://developer.apple.com/documentation/uikit/uidevice/1620015-name
Changes
$device_name
was set to the device's user name (eg Max's iPhone) for all events wrongly, it's now set to the device's name (eg iPhone 12), this happened only if usingreact-native-device-info
library.Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes