Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device_name was set to devices user name for all events wrongly #185

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Feb 20, 2024

Problem

https://github.com/react-native-device-info/react-native-device-info/blob/e46a5d4dba4e7d1f5e1da8b17c82829600f84d77/ios/RNDeviceInfo/RNDeviceInfo.m#L310-L333 is the correct method.
Instead of https://github.com/react-native-device-info/react-native-device-info/blob/e46a5d4dba4e7d1f5e1da8b17c82829600f84d77/ios/RNDeviceInfo/RNDeviceInfo.m#L150-L157 which returns https://developer.apple.com/documentation/uikit/uidevice/1620015-name

Changes

$device_name was set to the device's user name (eg Max's iPhone) for all events wrongly, it's now set to the device's name (eg iPhone 12), this happened only if using react-native-device-info library.

Release info Sub-libraries affected

Bump level

  • Major
  • Minor
  • Patch

Libraries affected

  • All of them
  • posthog-web
  • posthog-node
  • posthog-react-native

Changelog notes

  • Added support for X

Copy link

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@marandaneto marandaneto requested a review from a team February 20, 2024 15:49
@marandaneto marandaneto marked this pull request as ready for review February 20, 2024 15:49
@marandaneto marandaneto merged commit 36f7ac7 into main Feb 20, 2024
4 checks passed
@marandaneto marandaneto deleted the fix/rndi-device-name branch February 20, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants